bugfix/DEVSU-2445 rapid report kb matches bug fix #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update kb matches and evidence level splitting logic in rapid report with new kb matched statements response data structure - Update valueGetter logic for observed variants column in kb matches tables - Switch positions of observed variants and known variants columns back to original
kttkjl
reviewed
Nov 7, 2024
…ta structure (evidenceLevel and category being nested in kbmatchedstatements array since each variant can now have multiple statements) - Rework kbMatches statement categories handling in smallMutations, copyNumber, structuralVariants, and expressionOutliers to work with new kbmatches data structure - Fix ExpOutliersType missing in GeneType
…ches data structure - Update mockData for rapid report unit tests
elewis2
previously approved these changes
Nov 13, 2024
…ents-structure-bugs
kttkjl
reviewed
Nov 14, 2024
| valueGetter: (params) => { | ||
| const { data: { kbMatches } } = params; | ||
| if (kbMatches) { | ||
| const kbVariants = kbMatches?.map((match) => match.kbVariant).filter((kbVariant) => kbVariant !== undefined); |
There was a problem hiding this comment.
we can probably just use .filter no?
kbMatches?.filter((match) => match?.kbVariant);
There was a problem hiding this comment.
oh yea you're right let me simplify it
There was a problem hiding this comment.
@kttkjl actually I tried it and it didn't work, we still have to extract kbVariant from each match with .map() right?
There was a problem hiding this comment.
sorry, , oh yeah, we do have to map out the values toomatch.kbVariant && match.kbVariant !== undefined, maybe the shorthand is not enough
There was a problem hiding this comment.
in which case we'll use reduce
kbMatches?.reduce((acc, match) => {
if (match.kbVariant !== undefined) {
acc.push(match.kbVariant);
}
return acc;
}, []);
kttkjl
previously approved these changes
Nov 14, 2024
- Replace map+filter approach with reduce()
elewis2
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of [https://github.com//pull/571]