Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVSU-2024] undetermined diagnosis field #361

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

kttkjl
Copy link
Member

@kttkjl kttkjl commented Oct 16, 2023

Add logic when diagnosis is "undertermined", do not render the value

Cleaned up text rendering logic for Biopsy so it's cleaner

Fixed screenshot here

@kttkjl kttkjl self-assigned this Oct 16, 2023
@kttkjl kttkjl requested a review from elewis2 October 16, 2023 22:43
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f33912f) 16.09% compared to head (850873b) 16.12%.

❗ Current head 850873b differs from pull request most recent head 1f067ce. Consider uploading reports for the commit 1f067ce to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #361      +/-   ##
===========================================
+ Coverage    16.09%   16.12%   +0.03%     
===========================================
  Files          200      200              
  Lines         5823     5810      -13     
  Branches      1684     1676       -8     
===========================================
  Hits           937      937              
+ Misses        4218     4204      -14     
- Partials       668      669       +1     
Files Coverage Δ
app/views/PrintView/index.tsx 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kttkjl kttkjl merged commit a3690fc into develop Oct 20, 2023
5 checks passed
@kttkjl kttkjl deleted the feat/DEVSU-2024-undetermined-diagnosis-field branch October 20, 2023 17:25
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

Unit Test Results

    1 files  ±0    28 suites  ±0   2m 55s ⏱️ -36s
145 tests ±0  145 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
142 runs  ±0  142 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a3690fc. ± Comparison against base commit f33912f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants