Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVSU-2034] VUS add logic to show gene name + protein change #347

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

kttkjl
Copy link
Member

@kttkjl kttkjl commented Aug 17, 2023

Drafting this for now, questions to be answered in original ticket

Ready for review, confirmed changes needed

@kttkjl kttkjl self-assigned this Aug 17, 2023
@github-actions

This comment has been minimized.

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (795a435) 16.09% compared to head (e965579) 16.09%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #347      +/-   ##
===========================================
- Coverage    16.09%   16.09%   -0.01%     
===========================================
  Files          200      200              
  Lines         5802     5804       +2     
  Branches      1677     1678       +1     
===========================================
  Hits           934      934              
- Misses        4203     4204       +1     
- Partials       665      666       +1     
Files Coverage Δ
...s/ReportView/components/RapidSummary/columnDefs.ts 8.69% <0.00%> (-0.40%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kttkjl kttkjl requested a review from elewis2 August 17, 2023 23:48
@kttkjl kttkjl marked this pull request as ready for review August 17, 2023 23:48
@github-actions

This comment has been minimized.

@kttkjl kttkjl merged commit 3bb5b6e into develop Sep 26, 2023
5 checks passed
@github-actions
Copy link

Unit Test Results

    1 files  ±0    28 suites  ±0   32s ⏱️ -5s
146 tests ±0  146 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
143 runs  ±0  143 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3bb5b6e. ± Comparison against base commit 795a435.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants