-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/kbdev 1115 get cancer genes #104
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #104 +/- ##
==========================================
- Coverage 91.97% 90.33% -1.65%
==========================================
Files 8 8
Lines 835 838 +3
==========================================
- Hits 768 757 -11
- Misses 67 81 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Expected returned values can be deduced from here: https://svn.bcgsc.ca/bitbucket/rest/api/1.0/projects/DAT/repos/knowledgebase_datafixes/attachments/53 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. would be better to write a test for get_cancer_genes()
The base branch was changed.
As per DEVSU-2032/DEVSU-2038 requirements.
Following datafix KBDEV-1084.