Fix Invalid dependency graph created, cycle detected

bcgov · Oct 1, 2024 · ea1c117 · ea1c117
1 parent 7e4467e
commit ea1c117
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -244,6 +244,8 @@ jobs:
  TESTER_PASSWORD: ${{ secrets.TESTER_PASSWORD }}
  - name: Run SSL Certificate Test
  id: ssl-test
+ env:
+ APP_HOST_URL: ${{ needs.checkEnv.outputs.APP_NAME }}-${{ github.ref_name }}.apps.silver.devops.gov.bc.ca
  run: |
  # Perform SSL check
  SSL_EXPIRY_DAYS=$(node -e "
@@ -253,8 +255,6 @@ jobs:
  .catch(err => console.error(err));
  ")
  echo "SSL_EXPIRY_DAYS=$SSL_EXPIRY_DAYS" >> $GITHUB_ENV
- env:
- APP_HOST_URL: ${{ needs.checkEnv.outputs.APP_NAME }}-${{ github.ref_name }}.apps.silver.devops.gov.bc.ca
  - name: Set SSL Check Output
  id: ssl-output
  run: echo "SSL_EXPIRY_DAYS=${{ env.SSL_EXPIRY_DAYS }}" >> $GITHUB_OUTPUT

diff --git a/openshift/config/lighthouse/lighthouse-auth.js b/openshift/config/lighthouse/lighthouse-auth.js
@@ -1,4 +1,5 @@
 const puppeteer = require('puppeteer');
+
 const {URL} = require('url');
 const options = {
  chromeFlags: ['--headless'],
@@ -64,7 +65,6 @@ async function runLighthouse(url, options, config = null) {
  // Wait for both the click and navigation
  await Promise.all([
  page.click('a.sysadmin-login'),
- page.waitForNavigation({timeout: 10000}),
  page.click('#admin-login button[type="submit"]'),
  page.waitForNavigation({timeout: 60000}),
  ]);