ORV2-2834 - FE: Update: Change Start Application Menu and Steps #1635
Conversation
|
|
|
| } | ||
| > | ||
| <Button | ||
| className={`start-application-action__input ${open && "start-application-action__input--open"} ${isError && "start-application-action__input--error"}`} |
There was a problem hiding this comment.
This className seems too long, you might want to extract it out into a variable and assign the variable here instead.
There was a problem hiding this comment.
Also please use the proper ternary syntax rather than the "&&" approach, especially here in string interpolations (ie. use open ? "..." : "" instead of open && "...")
| open={open} | ||
| slotProps={{ | ||
| paper: { | ||
| className: `start-application-action__menu-container ${open && "start-application-action__menu-container--open"}`, |
There was a problem hiding this comment.
Please use proper ternary syntax here, and also consider extracting this long className into a variable
| Start Application | ||
| </Button> | ||
| </div> | ||
| {isError && ( |
There was a problem hiding this comment.
Use ternary operator here instead (ie. isError ? (<span>...</span>) : null)
Description
Implements the nested dropdown menu for selecting a permit application type.
Fixes #ORV2-2834
Type of change
Please delete options that are not relevant.
Checklist
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are promoted to: