ORV2-2578 - FE: Staff Manage Queue List #1627

glen-aot · 2024-10-01T18:22:00Z

Description

Implements application queue for staff users.

Fixes #ORV2-2578

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Checklist

I have read the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

Analysis Workflow

After merge, new images are promoted to:

Merge Workflow

…on-expiry-Date' into ORV2-2578

frontend/src/common/authentication/LoginRedirect.tsx

frontend/src/common/authentication/auth-walls/BCeIDAuthWall.tsx

frontend/src/common/components/naviconsidebar/NavIconHomeButton.tsx

frontend/src/features/queue/components/ApplicationsInQueueList.scss

frontend/src/features/queue/components/ClaimedApplicationsList.scss

frontend/src/features/queue/helpers/isStaffUser.ts

frontend/src/features/queue/hooks/hooks.ts

… using companyId, change companyId type from string to number

…ation response before passing as props to ApplicationInQueueReview

frontend/src/features/queue/components/ApplicationInQueueReview.tsx

frontend/src/features/queue/pages/ReviewApplicationInQueue.tsx

…2-2578

sonarcloud · 2024-10-10T16:29:47Z

Quality Gate passed for 'onroutebc_policy'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-10-10T16:29:59Z

Quality Gate passed for 'onroutebc dops'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-10-10T16:30:08Z

Quality Gate passed for 'onroutebc_scheduler'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-10-10T16:30:28Z

Quality Gate passed for 'onroutebc vehicles'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-10-10T16:30:36Z

Quality Gate failed for 'onroutebc frontend'

Failed conditions
29.2% Coverage on New Code (required ≥ 80%)
9.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

praju-aot and others added 21 commits July 24, 2024 12:12

Add GA and POS to CGI File

11d2be3

Merge branch 'main' into ORV2-2578

6cfe940

Merge remote-tracking branch 'origin/main' into ORV2-2578

9bfc8d4

Merge remote-tracking branch 'origin/main' into ORV2-2578

ea19a01

getApplicationsInQueue hook and API functionality

1041aa1

move ApplicationFilters interface

7decccf

staff queue table

5078e5b

Merge remote-tracking branch 'origin/main' into ORV2-2578

af2461d

Merge remote-tracking branch 'origin/main' into ORV2-2578

26422db

Merge remote-tracking branch 'origin/main' into ORV2-2578

efb9341

Merge remote-tracking branch 'origin/main' into ORV2-2578

98d2c29

fix: Rectify the expiry date validation

161a015

reject application

1a216e9

Merge remote-tracking branch 'origin/fix/ORV2-2792---Incorrect-check-…

83920be

…on-expiry-Date' into ORV2-2578

approve application in queue

38b1f00

Correct the if condition for date check

f3cc91a

Merge remote-tracking branch 'origin/fix/ORV2-2792---Incorrect-check-…

59aba3c

…on-expiry-Date' into ORV2-2578

approve application in queue

cc34519

pre merge main

b4ebf2a

Merge remote-tracking branch 'origin/main' into ORV2-2578

91b0e6d

update PERMIT_TYPES_FOR_QUEUE

e728975

glen-aot requested review from krishnan-aot and zgong-gov as code owners October 1, 2024 18:22

glen-aot temporarily deployed to dev October 1, 2024 18:24 — with GitHub Actions Inactive

zgong-gov reviewed Oct 2, 2024

View reviewed changes

PR review changes

551c06c

glen-aot temporarily deployed to dev October 3, 2024 22:22 — with GitHub Actions Inactive

Merge branch 'main' into ORV2-2578

1b816fd

zgong-gov temporarily deployed to dev October 4, 2024 01:19 — with GitHub Actions Inactive

Complete refactoring of permit and vehicles related hooks and methods…

1f8705d

… using companyId, change companyId type from string to number

Merge branch 'main' into ORV2-2578

4391a5e

zgong-gov temporarily deployed to dev October 8, 2024 02:32 — with GitHub Actions Inactive

Refactor code related to confirmation checkboxes

b0cbfd1

zgong-gov temporarily deployed to dev October 8, 2024 04:07 — with GitHub Actions Inactive

remove navigate(APPLICATION_QUEUE_ROUTES.EDIT) and deserialize applic…

70f189a

…ation response before passing as props to ApplicationInQueueReview

glen-aot requested review from gchauhan-aot and praju-aot as code owners October 9, 2024 15:57

glen-aot temporarily deployed to dev October 9, 2024 16:00 — with GitHub Actions Inactive

Merge remote-tracking branch 'origin/main' into ORV2-2578

e760c69

glen-aot temporarily deployed to dev October 9, 2024 16:05 — with GitHub Actions Inactive

zgong-gov reviewed Oct 9, 2024

View reviewed changes

frontend/src/features/queue/components/ApplicationInQueueReview.tsx Show resolved Hide resolved

frontend/src/features/queue/pages/ReviewApplicationInQueue.tsx Show resolved Hide resolved

update ConfirmationCheckboxes.scss

a51fb79

glen-aot temporarily deployed to dev October 9, 2024 20:16 — with GitHub Actions Inactive

remove edit button

2926afb

glen-aot temporarily deployed to dev October 9, 2024 22:33 — with GitHub Actions Inactive

Merge branch 'main' into ORV2-2578

bfbba8b

glen-aot temporarily deployed to dev October 9, 2024 22:40 — with GitHub Actions Inactive

glen-aot added 3 commits October 9, 2024 15:42

update PERMIT_TYPES_FOR_QUEUE

6e91d6d

Merge remote-tracking branch 'origin/main' into ORV2-2578

00cd37f

Merge remote-tracking branch 'refs/remotes/origin/ORV2-2578' into ORV…

8eed161

…2-2578

glen-aot temporarily deployed to dev October 10, 2024 16:29 — with GitHub Actions Inactive

zgong-gov approved these changes Oct 10, 2024

View reviewed changes

glen-aot merged commit 99a3b58 into main Oct 10, 2024
22 of 23 checks passed

glen-aot deleted the ORV2-2578 branch October 10, 2024 17:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ORV2-2578 - FE: Staff Manage Queue List #1627

ORV2-2578 - FE: Staff Manage Queue List #1627

glen-aot commented Oct 1, 2024 •

edited

Loading

sonarcloud bot commented Oct 10, 2024

sonarcloud bot commented Oct 10, 2024

sonarcloud bot commented Oct 10, 2024

sonarcloud bot commented Oct 10, 2024

sonarcloud bot commented Oct 10, 2024

ORV2-2578 - FE: Staff Manage Queue List #1627

ORV2-2578 - FE: Staff Manage Queue List #1627

Conversation

glen-aot commented Oct 1, 2024 • edited Loading

Description

Type of change

Checklist

Further comments

sonarcloud bot commented Oct 10, 2024

Quality Gate passed for 'onroutebc_policy'

sonarcloud bot commented Oct 10, 2024

Quality Gate passed for 'onroutebc dops'

sonarcloud bot commented Oct 10, 2024

Quality Gate passed for 'onroutebc_scheduler'

sonarcloud bot commented Oct 10, 2024

Quality Gate passed for 'onroutebc vehicles'

sonarcloud bot commented Oct 10, 2024

Quality Gate failed for 'onroutebc frontend'

glen-aot commented Oct 1, 2024 •

edited

Loading