ORV2 2299 LOA #1486
Closed
ORV2 2299 LOA #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…outebc into ORV2-2299-loa-db-setup
# Conflicts: # database/mssql/scripts/versions/revert/v_31_ddl_revert.sql # database/mssql/scripts/versions/v_31_ddl.sql # database/mssql/test/versions/v_31_1_test.sql # database/mssql/test/versions/v_31_test.sh
…se when download mode is not proxy
… into ORV2-2299-loa-db-setup
praju-aot
reviewed
Jul 19, 2024
|
|
||
| @LogAsyncMethodExecution() | ||
| async deleteLoaDocument(companyId: number, loaId: number): Promise<number> { | ||
| const { affected } = await this.loaDetailRepository.update( |
There was a problem hiding this comment.
Please send the correct response message with success or failure instead of the affected row numbers
There was a problem hiding this comment.
@praju-aot Also the same should be done for async delete() as well? Sending success/failure rather than affected row numbers
vehicles/src/modules/loa/dto/request/queryParam/get-loa.query-params.dto.ts
Outdated
Show resolved
Hide resolved
|
Stale image |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for LOA DB set up and CRUD endpoints.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are promoted to: