Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VDYP-164 Load FIPStart data files #18

Merged
merged 87 commits into from
Jan 10, 2024
Merged

VDYP-164 Load FIPStart data files #18

merged 87 commits into from
Jan 10, 2024

Conversation

smithkm
Copy link
Collaborator

@smithkm smithkm commented Jul 20, 2023

No description provided.

smithkm added 30 commits May 2, 2023 19:55
@smithkm
Control file parser
2041ae0
@smithkm
Docs, new test, refinements to configuring control file parser
37e085b
@smithkm
Write control file
dcb48f2
@smithkm
Parsing Fip control file
a410ac7
@smithkm
Progress on parsing data files
a08c0a0
@smithkm
Rewrite control file parser to use LineParser
92487ac
@smithkm
BecParserTest
262164d
@smithkm
Docs and refinements
3e93b27
@smithkm
FIP Control parsing
1aa2dd1
@smithkm
Merge branch 'main' of github.com:bcgov/VDYP
b48d5b4
@smithkm
Read SP0 definitions
93c6554
@smithkm
Volume Equation Group Parsing
4b017f7
@smithkm
VolumeEquationGroupParser
876e13e
@smithkm
Move control key for volume eqn group to parser
c763600
@smithkm
Decay and breakage groups
2a5763c
@smithkm
Validate that SP0-BEC->Group ID mappings are complete
f2ae928
@smithkm
Parse equation modifier data file
dad77be
@smithkm
Parse stocking factor
dae7cd9
@smithkm
Site Curve parsing and ran formatter
34f165f
@smithkm
Site curve age max loading
4b1a0fb
@smithkm
CoefficientParser
e326fb8
@smithkm
Upper Coeficcient parser, and fixes for regular coefficient parser
7d1f30e
@smithkm
HL coefficient parser
6e4741a
@smithkm
Nonprimary coefficient parser
45f7be2
@smithkm
Run formattter
a591af7
@smithkm
BySpeciesDqCoefficientParser
faf23ca
@smithkm
Componetn size limit
3e10ac3
@smithkm
UtilComponentBaseAreaParser
40f3a5d
@smithkm
Stubbing FIP parser methods
14faf65
@smithkm
Formatter
72ca5aa
@smithkm
Refactor LineParser to allow for streaming parsers to be built on top…
7207729 
… of it
@smithkm
Parser for polygon data file
e86784d
@smithkm
Working on parser for polygon data
cc3b86b
@smithkm
Parsing polygon data file
01af9f7
@smithkm
Load fip polygon datafile from control file
1d7a0f3
@smithkm
Remove unused imports
8415f68
@smithkm
Fix raw type warning in test
3660fd2
@smithkm
Fix unused variable warings in unit tests
c84e10b
@smithkm
Remove BecModifier as it is not needed
562c641
@smithkm
Merge branch 'feature/VDYP-120' into feature/VDYP-164
6f07143
@smithkm
Fix unused imports
bad1ba0
@smithkm
Class to replicate type union
f4a615a
@smithkm
Loading FIP layer data file
98cb956
@smithkm
Parsing layer-species data file
6abc2d2
@smithkm
Merge branch 'main' into feature/VDYP-120
48cdf3a
@smithkm
Merge branch 'feature/VDYP-120' into feature/VDYP-164
c0c9d23
@smithkm
Prevent shallow clone so SonarCloud can work correctly.
f94257e
@smithkm smithkm added the enhancement New feature or request label Jul 20, 2023
@smithkm smithkm requested review from kcguise and eddeen July 20, 2023 23:09
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 181 Code Smells

80.2% 80.2% Coverage
0.7% 0.7% Duplication

eddeen
eddeen approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@eddeen eddeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although there are lots of "smell test" idiosyncrasies - I kind of understand your coding preferences for the items I looked at.

@smithkm smithkm merged commit c140d41 into main Jan 10, 2024
3 checks passed
@smithkm smithkm deleted the feature/VDYP-164 branch January 10, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddeen eddeen eddeen approved these changes

@kcguise kcguise Awaiting requested review from kcguise

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smithkm @eddeen