fix: Update python version in terraform to keep consistent #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agement into fix/test-container
|
Hi Ian, I wonder if you know what this "version: 3.8" means here? It's in all three docker compose files @ianliuwk1019 |
Hm... I don't think I know the reason. They were probably inherit from (copy-paste) the first docker-compose file, but I don't know why it was 3.8. I think we could remove this "version" to avoid confusion, the docker docs says it is not being used. |
ianliuwk1019
previously approved these changes
Aug 7, 2024
|
ianliuwk1019
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade python to v3.12 in terraform to be the same version in the GitHub pipeline workflow yamls.
We got a deployment error when merged pr #1517 https://github.com/bcgov/nr-forests-access-management/actions/runs/10275482241, the Api Gateway is not reachable. It's caused by a python version mismatch issue. After manually set the lambda python version to 3.12, the Api Gateway works again.
