-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #1139 add forest client validator #1176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agement into feat/1139-add-forest-client-validator
…agement into feat/1139-add-forest-client-validator
ianliuwk1019
reviewed
Feb 7, 2024
server/admin_management/api/app/services/access_control_privilege_service.py
Outdated
Show resolved
Hide resolved
ianliuwk1019
reviewed
Feb 7, 2024
server/admin_management/api/app/services/access_control_privilege_service.py
Outdated
Show resolved
Hide resolved
ianliuwk1019
reviewed
Feb 7, 2024
server/admin_management/api/app/services/access_control_privilege_service.py
Outdated
Show resolved
Hide resolved
…agement into feat/1139-add-forest-client-validator
Quality Gate passed for 'nr-forests-access-management_admin'Issues Measures |
ianliuwk1019
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate with forest client api to verify forest client number when creating access control privilege for delegated admin
refs: #1139
When create the access control privileges with multiple forest client numbers, as long as one of the forest client number is inactive or invalid, return the validation error