Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #1010 admin api gateway #1050

Merged
merged 15 commits into from
Nov 24, 2023
Merged

feat: #1010 admin api gateway #1050

merged 15 commits into from
Nov 24, 2023

Conversation

ianliuwk1019
Copy link
Collaborator

@ianliuwk1019 ianliuwk1019 commented Nov 22, 2023

  • A new API admin_management_api_gateway Gateway.
  • Associate new API gateway with new fam_admin_management_api lambda.
  • Add api-gateway url to Cognito callbackUrl.
  • Prepared terraform "output" for new api url.
    image

success + 200 + 13 ?!! :
image

@ianliuwk1019 ianliuwk1019 changed the title feat:1#1010 admin api gateway feat: #1010 admin api gateway Nov 22, 2023
@MCatherine1994
Copy link
Contributor

MCatherine1994 commented Nov 23, 2023

Hi Ian, I think we need to add the Api Gateway doc url to Cognito callback urls, something like below, so we can login to the swagger console and try our endpoint

callback_urls                        = "${concat(var.fam_callback_urls, ["${aws_api_gateway_deployment.fam_api_gateway_deployment.invoke_url}/docs/oauth2-redirect"])}"

And maybe we can remove the manual created one in tools space, thanks!!

@ianliuwk1019
Copy link
Collaborator Author

Hi Ian, I think we need to add the Api Gateway doc url to Cognito callback urls, something like below, so we can login to the swagger console and try our endpoint

callback_urls                        = "${concat(var.fam_callback_urls, ["${aws_api_gateway_deployment.fam_api_gateway_deployment.invoke_url}/docs/oauth2-redirect"])}"

And maybe we can remove the manual created one in tools space, thanks!!

That's right, I will add this and update the acceptance criteria for this ticket.
Hm... just realized there are more to it now for this api gateway..... I will create a new ticket for some other work related to this new api gateway, but the url will be added to Cognito with this ticket.
Thanks Catherine!!

@MCatherine1994
Copy link
Contributor

MCatherine1994 commented Nov 23, 2023

Hi Ian, I tried the smoke test router in our new Api Gateway, but I got the internal server error, I checked the CloudWatch logs and found it complains the key error...
Screen Shot 2023-11-23 at 1 52 54 PM

@ianliuwk1019
Copy link
Collaborator Author

Hi Ian, I tried the smoke test router in our new Api Gateway, but I got the internal server error, I checked the CloudWatch logs and found it complains the key error... Screen Shot 2023-11-23 at 1 52 54 PM

Hi Catherine, I tried again with swagger, it does not have issue with 200 success from the smoke_test.
Were you test in different way?
Also, if the api-gateway reaches the lambda, then api-gateway works since its job is only a proxy passing all requests to the lambda.
Please let me know if I can try it out on your way.

Copy link

sonarcloud bot commented Nov 24, 2023

[nr-forests-access-management_admin] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@basilv basilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, more of a question. Otherwise looks good.

@ianliuwk1019 ianliuwk1019 merged commit b61aeba into main Nov 24, 2023
15 checks passed
@ianliuwk1019 ianliuwk1019 deleted the feat/1010-admin-api-gateway branch November 24, 2023 20:05
NickSaglioni pushed a commit that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants