Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #1007 new fam app admin model #1029

Merged
merged 7 commits into from
Nov 10, 2023

Conversation

ianliuwk1019
Copy link
Collaborator

@ianliuwk1019 ianliuwk1019 commented Nov 8, 2023

  • Add V32 flyway script for new "fam_application_admin" table.
  • Add new proxy db user in V32 flyway script and grant privilege on "fam_application_admin", "fam_application" and "fam_user" tables.
  • Add ORM mapping to the existing model.py for new table and relationship.
  • Add new environment place_holder values for flyway migration for Docker compose and for terraform.

docker-base-services.yml Outdated Show resolved Hide resolved
MCatherine1994
MCatherine1994 previously approved these changes Nov 9, 2023
@MCatherine1994
Copy link
Contributor

also wondering do we need to add the new db user to this file? not sure what this is for....
Screen Shot 2023-11-09 at 4 00 08 PM

@ianliuwk1019
Copy link
Collaborator Author

Hi @basilv I have updated the password to be some temporary dummy value. Catherine review and approves it. Will merge this one for Catherine to continue on her task; password will be then changed.

also wondering do we need to add the new db user to this file? not sure what this is for.... Screen Shot 2023-11-09 at 4 00 08 PM

I don't know what this file is for, never hear from others before, and I feel we don't need to change it as I don't even see lambda api here. I feel it is ok. When testing the terraform in task 2, we can see if our change is working.

@ianliuwk1019 ianliuwk1019 merged commit f7f341f into main Nov 10, 2023
12 checks passed
@ianliuwk1019 ianliuwk1019 deleted the feat/1007-new-fam-app-admin-model branch November 10, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants