fix: CE-1078 persist secret content changes between rollouts #698
Conversation
|
Closing to test cleanup |
|
Please retry analysis of this Pull-Request directly on SonarCloud |
| @@ -43,5 +43,6 @@ Selector labels | |||
| {{- define "selectorLabels" -}} | |||
| app.kubernetes.io/name: {{ include "fullname" . }} | |||
| app.kubernetes.io/instance: {{ .Release.Name }} | |||
| app: {{ .Release.Name }} | |||
There was a problem hiding this comment.
do we need this new label?
There was a problem hiding this comment.
It's so that this label variant of the cleanup action can be re-used here
As the helm pr-close here https://github.com/bcgov/quickstart-openshift-helpers/blob/main/.github/workflows/.pr-close.yml#L161 does not allow flag passthrough. Specificaly in this case global.secrets.persist=false as the dev team would like secret workloads to persist in their dev environments.
There was a problem hiding this comment.
changes to their secret workloads to persist between deployments*
There was a problem hiding this comment.
lets discuss this, as clean up with label will make helm to stick around with secret objects, @DerekRoberts and I can look at the helper function to add in necessary flags as needed or we can add you as a collaborator on those repos :)
There was a problem hiding this comment.
I am sorry.
I misunderstood the change, I see now, that you are cleaning up with helm then with label to make sure the persisted secret is deleted with labels, as helm wont delete them during uninstall
I will keep that into our helper as a backlog item, so we don't do twice cleanups :)
|
Closing to test cleanup |
|
Description
Allows developers to change the service-specific secret values for testing, and have those values persist between helm installs / re-deploys. Secrets are cleaned up on PR close still.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
helm.sh/resource-policy: keepannotation, and persist between deploysChecklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: