Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test:Remove crucial data from Submission payload #25

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

ptugger
Copy link

@ptugger ptugger commented Aug 31, 2023

Description

This PR contains improvements to Multi upload submissions where we need remove un-necessery information
from the json payload of submissions. It will also help to remove crucial data
to be removed from the payload that should not be going to DB like confirmationId,
formName,version,createdAt,fullName,username,email,status,assignee,assigneeEmail and
ateEntry
Example: Sometime end user use the export json file as a bulk
upload payload that contains formId, confirmationId and User
details as well so we need to remove those details from the payload.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

@evgeny-pluzhnikov evgeny-pluzhnikov merged commit cc4a36a into master Aug 31, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants