-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JASPER-126: Create network components #33
Conversation
- Simplify security groups rules - Added provisioned subnets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend adding some IP restrictions on the ingress rules, especially when it comes to port 22.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll defer to @amlanc1 for final review and approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Pull Request for JIRA Ticket: JIRA-126
Issue ticket number and link
https://jag.gov.bc.ca/jira/browse/JASPER-126
Description
Type of change
How Has This Been Tested?
Tested by creating 2 EC2 instances and ping each other's private ip address.
Checklist: