Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JASPER-126: Create network components #33

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Conversation

ronaldo-macapobre
Copy link

Pull Request for JIRA Ticket: JIRA-126

Issue ticket number and link

https://jag.gov.bc.ca/jira/browse/JASPER-126

Description

  • Simplify ingress/egress rules for Security Group
  • Set up traffic routing between ECS and Lambda Security Groups.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested by creating 2 EC2 instances and ping each other's private ip address.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Ronaldo Macapobre added 2 commits October 12, 2024 00:04
- Simplify security groups rules
- Added provisioned subnets
Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend adding some IP restrictions on the ingress rules, especially when it comes to port 22.

Copy link

sonarcloud bot commented Oct 16, 2024

Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to @amlanc1 for final review and approval

Copy link

@amlanc1 amlanc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronaldo-macapobre ronaldo-macapobre merged commit 2df0618 into master Oct 17, 2024
5 checks passed
@ronaldo-macapobre ronaldo-macapobre deleted the feature/JASPER-126 branch October 17, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants