Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCVP-3152: Add filtering by surname or org name #2045

Conversation

karahanb
Copy link
Contributor

Description

This PR includes the following proposed change(s):

  • TCVP-3152
  • Added functionality to search by disputant surname or organization name through jj dispute search endpoint utilizing the new 'prof_surname_nm_or_org_nm' ords query parameter.
  • Added 'disputantOrganizationName' field to return as part of dcf search request's response.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation
  • Version change

if your change is a breaking change, please add breaking change label to this PR

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Does the change impact or break the Docker build?

  • Yes
  • No

If Yes: Has Docker been updated accordingly?

  • Yes
  • No

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

…nization name through jj dispute search endpoint utilizing the new 'prof_surname_nm_or_org_nm' ords query parameter. Added 'disputantOrganizationName' field to return as part of dcf search request's response
@karahanb karahanb added enhancement New feature or request staff-api Pertains to the Staff API (backend) release 2.6 labels Jan 13, 2025
@karahanb karahanb requested a review from pbolduc January 13, 2025 22:24
Copy link
Contributor

@pbolduc pbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest updating the sort by parameter to include the new pseudo sort field surnameOrOrgName since it is not a field in the response and it may not be obvious that this is the field you can sort on. See <param name="sort_by">

…ndicate 'surnameOrOrgName' can be used for sorting by surname or organization name
@karahanb
Copy link
Contributor Author

I would suggest updating the sort by parameter to include the new pseudo sort field surnameOrOrgName since it is not a field in the response and it may not be obvious that this is the field you can sort on. See <param name="sort_by">

Added a note to sort_by parameter for search endpoint to indicate 'surnameOrOrgName' can be used for sorting by surname or organization name.

@karahanb karahanb requested a review from pbolduc January 14, 2025 15:19
@karahanb karahanb changed the base branch from develop to release/2.7 January 15, 2025 19:00
@karahanb karahanb merged commit 6bd72e4 into release/2.7 Jan 16, 2025
9 checks passed
@karahanb karahanb deleted the feature/TCVP-3152-add-filtering-and-sorting-by-surname-or-org-name branch January 16, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release 2.7 staff-api Pertains to the Staff API (backend)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants