Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23337 - Add Court Order to Limited Restoration Extension Filing #695

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

ArwenQin
Copy link
Collaborator

@ArwenQin ArwenQin commented Oct 3, 2024

Issue #: /bcgov/entity#23337

Description of changes:

  • Fixed: A Limited Restoration Extension was filed with a court order. The ledger should display the court order number.
  • Tested A limit Restoration to full shows the court order properly.
  • Tested other filing types where staff can enter a court order number (and POA) and verify that the respective ledger items show it.
    Issue: Future Effective Voluntary Dissolution didn't show court order number.
    Other types show properly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

@ArwenQin
Copy link
Collaborator Author

ArwenQin commented Oct 3, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-filings-dev--pr-695-5gyuotob.web.app

@ArwenQin
Copy link
Collaborator Author

ArwenQin commented Oct 3, 2024

See:
https://business-filings-dev--pr-695-5gyuotob.web.app/BC1218838?filing_id=151349&accountid=3040

Updated:
image

@ArwenQin
Copy link
Collaborator Author

ArwenQin commented Oct 3, 2024

A limit Restoration to full shows the court order properly: (no change)
image

@ArwenQin
Copy link
Collaborator Author

ArwenQin commented Oct 3, 2024

Tested other filing types where staff can enter a court order number (and POA) and verify that the respective ledger items show it.

  • Tested ok: Incorporation, Consent to Continue Out, Registrar's Notation, Registrar's Order, Court Order, Continuation Out
    with: BC0883602
  • Issue: Future Effective Voluntary Dissolution didn't show court order number.
    image
    This is because for the FE Voluntary Dissolution, the required data is not present (this.filing.data)
    image

see BC0883603
This issue is in the BodyFutureEffective.vue, and BodyFutureEffectivePending.vue, shall we fix it?
FE incorporation is good. I'm not sure if there are other filing types that can do FE after incorporation?

@ArwenQin ArwenQin self-assigned this Oct 3, 2024
@severinbeauvais
Copy link
Collaborator

  • Issue: Future Effective Voluntary Dissolution didn't show court order number.
    This is because for the FE Voluntary Dissolution, the required data is not present (this.filing.data)

Check with Vysakh on whether the court order/POA data should be there. Note that, since this filing is FE, the Filer has not processed it yet. Maybe some back end work is needed to fix this.

This issue is in the BodyFutureEffective.vue, and BodyFutureEffectivePending.vue, shall we fix it? FE incorporation is good. I'm not sure if there are other filing types that can do FE after incorporation?

Which filings use those sub-components? Please check the UIs to see what other filings can be FE (and whether they prompt for court order/POA). I don't know this by heart :)

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. I'll wait for answers about the other filings before I approve, as you might have additional code changes.

Signed-off-by: Qin <[email protected]>
Copy link

sonarcloud bot commented Oct 4, 2024

@ArwenQin
Copy link
Collaborator Author

ArwenQin commented Oct 7, 2024

/gcbrun

@ArwenQin
Copy link
Collaborator Author

ArwenQin commented Oct 7, 2024

@severinbeauvais
Is it approved to merge now? Thanks.

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-filings-dev--pr-695-5gyuotob.web.app

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Merge away!

@ArwenQin ArwenQin merged commit 042b873 into bcgov:main Oct 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants