Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cronjob Deployment Configs #1433

Merged
merged 25 commits into from
Nov 27, 2024
Merged

Conversation

MacQSL
Copy link
Collaborator

@MacQSL MacQSL commented Nov 19, 2024

Links to Jira Tickets

  • {Include a link to all applicable Jira tickets}

Description of Changes

  • {List all relevant code changes. Include any changes to the business workflow that might not be obvious to the reviewers of this PR.}

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

@MacQSL MacQSL changed the base branch from dev to SIMSBIOHUB-627 November 20, 2024 21:01
@MacQSL MacQSL changed the base branch from SIMSBIOHUB-627 to dev November 20, 2024 21:02
@MacQSL MacQSL changed the base branch from dev to SIMSBIOHUB-627 November 20, 2024 21:43
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (SIMSBIOHUB-627@94b2293). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             SIMSBIOHUB-627    #1433   +/-   ##
=================================================
  Coverage                  ?   45.06%           
=================================================
  Files                     ?      847           
  Lines                     ?    22593           
  Branches                  ?     3306           
=================================================
  Hits                      ?    10181           
  Misses                    ?    11833           
  Partials                  ?      579           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 20, 2024

@MacQSL MacQSL changed the title Cronjob Openshift: Do not merge Cronjob Deployment Configs Nov 20, 2024
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just skimmed over the code changes, and took a look at the Openshift resources that were deployed. Seems like everything is in order.

@MacQSL MacQSL merged commit 5bf290e into SIMSBIOHUB-627 Nov 27, 2024
20 checks passed
@MacQSL MacQSL deleted the mdTelemetry-cronjob-openshift branch November 27, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants