Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Adjust Sampling Data Container Styling #1395

Merged
merged 10 commits into from
Nov 22, 2024
Merged

UI: Adjust Sampling Data Container Styling #1395

merged 10 commits into from
Nov 22, 2024

Conversation

mauberti-bc
Copy link
Collaborator

Links to Jira Tickets

  • N/A

Description of Changes

  • Changes styling of the sampling data container
  • CSS adjustments across the Survey page and related pages

Testing Notes

  • No change to functionality

@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 19.61538% with 209 lines in your changes missing coverage. Please review.

Project coverage is 45.30%. Comparing base (be4656f) to head (588ea76).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...nts/sampling-data/SurveySamplingTableContainer.tsx 0.00% 45 Missing ⚠️
...ling-data/components/period/SurveyPeriodsTable.tsx 0.00% 19 Missing ⚠️
...ponents/technique/SurveyTechniqueCardContainer.tsx 0.00% 17 Missing ⚠️
...-location-repository/sample-location-repository.ts 51.85% 13 Missing ⚠️
...ormation/techniques/SamplingTechniqueContainer.tsx 0.00% 13 Missing ⚠️
...nents/technique/components/SurveyTechniqueCard.tsx 0.00% 13 Missing ⚠️
...ling-information/sites/table/SamplingSiteTable.tsx 0.00% 10 Missing ⚠️
...rmation/sites/table/SamplingSiteTableContainer.tsx 0.00% 10 Missing ⚠️
...qualitative/TechniqueCardQualitativeAttributes.tsx 0.00% 8 Missing ⚠️
...uantitative/TechniqueCardQuantitativeAttribute.tsx 0.00% 7 Missing ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1395      +/-   ##
==========================================
- Coverage   45.43%   45.30%   -0.14%     
==========================================
  Files         817      828      +11     
  Lines       21976    22111     +135     
  Branches     3271     3290      +19     
==========================================
+ Hits         9985    10017      +32     
- Misses      11396    11499     +103     
  Partials      595      595              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@NickPhura NickPhura removed the Ready For Review PR is ready for review label Oct 24, 2024
@mauberti-bc mauberti-bc added the Not Ready For Review Addressing feedback and/or refactoring label Nov 6, 2024
@mauberti-bc
Copy link
Collaborator Author

I suspect this might conflict with some of the ready-for-review PRs so we can let this sit until the more important PRs get merged in.

@mauberti-bc mauberti-bc added Ready For Review PR is ready for review and removed Not Ready For Review Addressing feedback and/or refactoring labels Nov 18, 2024
@NickPhura NickPhura marked this pull request as ready for review November 22, 2024 02:08
Copy link

sonarcloud bot commented Nov 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
9.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍍

@NickPhura NickPhura merged commit 8f48b31 into dev Nov 22, 2024
20 of 23 checks passed
@NickPhura NickPhura deleted the sampling-container branch November 22, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants