Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styling for the Add User form #1355

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Update styling for the Add User form #1355

merged 4 commits into from
Sep 4, 2024

Conversation

mauberti-bc
Copy link
Collaborator

Links to Jira Tickets

  • N/A

Description of Changes

  • Updates styling on the Add User form for manual inserts
  • Changed the form to handle only one user a time

Testing Notes

  • Should be able to add users

@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 47.01%. Comparing base (bb198fa) to head (69553ba).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...pp/src/features/admin/users/AddSystemUsersForm.tsx 0.00% 12 Missing ⚠️
app/src/features/admin/users/ActiveUsersList.tsx 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1355      +/-   ##
==========================================
+ Coverage   46.98%   47.01%   +0.03%     
==========================================
  Files         738      738              
  Lines       19894    19887       -7     
  Branches     3067     3062       -5     
==========================================
+ Hits         9347     9350       +3     
+ Misses       9979     9969      -10     
  Partials      568      568              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauberti-bc mauberti-bc changed the title Update the Add User form Update styling for the Add User form Aug 28, 2024
MacQSL
MacQSL previously approved these changes Sep 4, 2024
Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖

@mauberti-bc mauberti-bc marked this pull request as ready for review September 4, 2024 21:51
Copy link

sonarcloud bot commented Sep 4, 2024

Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕‍🦺

@mauberti-bc mauberti-bc merged commit bb4f7dd into dev Sep 4, 2024
21 of 22 checks passed
@mauberti-bc mauberti-bc deleted the add-system-user branch September 4, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants