BugFix: Update Migration To Fix Lingering Duplicate Users Issue #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Openshift URLs for the PR Deployment: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1347 +/- ##
=======================================
Coverage 46.94% 46.94%
=======================================
Files 753 753
Lines 20276 20277 +1
Branches 3114 3114
=======================================
+ Hits 9518 9519 +1
Misses 10180 10180
Partials 578 578 ☔ View full report in Codecov by Sentry. |
NickPhura
added
Early Feedback Welcome
mauberti-bc
previously approved these changes
Aug 28, 2024
MacQSL
reviewed
Sep 3, 2024
|
Openshift URLs for the PR Deployment: |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
n/a
Description of Changes
Update the existing migration that was meant to fix duplicate user issues, but which left some issues unfixed.
Testing Notes
On a new local build, it should delete all duplicate users (rather than end-date them), and should now correctly prevent duplicate user records from being created.
user_guidand unique (user_Identifier+user_identity_source).Editing Existing Migration
Normally we dont edit existing migrations, but since this is only in Test, and it only touches the system_user table, it was easier to just modify it, and then I'll manually run some queries to account for the differences in Dev and Test (since this migration wont re-run in either of those environments)