Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View past access requests in Manage User table #1346

Merged
merged 9 commits into from
Sep 5, 2024
Merged

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Aug 23, 2024

Links to Jira Tickets

  • N/A

Description of Changes

  • Show pending, approved and rejected requests on the Manage Users page
  • Allow the details of approved and rejected requests to be viewed
  • Add access requests to the database seed
  • Reorganizes Manage User-related files in the app

@mauberti-bc mauberti-bc added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 29.11392% with 56 lines in your changes missing coverage. Please review.

Project coverage is 46.62%. Comparing base (36009c9) to head (ae594c9).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...quests/list/actioned/AccessRequestActionedList.tsx 6.66% 14 Missing ⚠️
...requests/list/pending/AccessRequestPendingList.tsx 22.22% 14 Missing ⚠️
...quests/list/rejected/AccessRequestRejectedList.tsx 6.66% 14 Missing ⚠️
...n/users/access-requests/AccessRequestContainer.tsx 66.66% 4 Missing and 3 partials ⚠️
...rc/features/admin/users/active/ActiveUsersList.tsx 20.00% 4 Missing ⚠️
...cess-requests/components/ViewAccessRequestForm.tsx 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1346      +/-   ##
==========================================
- Coverage   46.94%   46.62%   -0.33%     
==========================================
  Files         753      757       +4     
  Lines       20277    20330      +53     
  Branches     3114     3120       +6     
==========================================
- Hits         9519     9478      -41     
- Misses      10180    10276      +96     
+ Partials      578      576       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickPhura NickPhura marked this pull request as draft August 23, 2024 18:17
MacQSL
MacQSL previously approved these changes Sep 4, 2024
Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works great! 🧄

@mauberti-bc mauberti-bc marked this pull request as ready for review September 4, 2024 23:42
MacQSL
MacQSL previously approved these changes Sep 4, 2024
Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆎

Copy link

sonarcloud bot commented Sep 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@mauberti-bc mauberti-bc merged commit e1a31b8 into dev Sep 5, 2024
19 of 22 checks passed
@mauberti-bc mauberti-bc deleted the access-request-seed branch September 5, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Early Feedback Welcome PR is not finished, but early review feedback is welcomed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants