Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Change itis_tsn column type in CSV validator #1345

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Aug 22, 2024

Links to Jira Tickets

  • N/A

Description of Changes

  • Fixes a bug preventing observations from being imported by changing the ITIS_TSN column type from 'string' to 'number' in the CSV validator

Testing Notes

  • Should be able to import observations from a CSV file

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.92%. Comparing base (d4e0f59) to head (1704975).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1345   +/-   ##
=======================================
  Coverage   47.92%   47.92%           
=======================================
  Files         737      737           
  Lines       20027    20027           
  Branches     3146     3146           
=======================================
  Hits         9597     9597           
  Misses       9825     9825           
  Partials      605      605           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Aug 22, 2024
Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIPIT 🚢

Copy link

sonarcloud bot commented Aug 26, 2024

@MacQSL MacQSL merged commit 2fedbf1 into dev Aug 26, 2024
22 checks passed
@MacQSL MacQSL deleted the bugFix-obs-import branch August 26, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants