SIMSBIOHUB-600: Handle Keycloak Auto-Renew Error, Write Logs to File #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly declare the automaticSilentRenew flag in the authConfig. Remove deprecated comment from useAxios.ts
|
Openshift URLs for the PR Deployment: |
NickPhura
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1342 +/- ##
==========================================
+ Coverage 47.89% 47.92% +0.02%
==========================================
Files 737 737
Lines 20007 20027 +20
Branches 3137 3146 +9
==========================================
+ Hits 9582 9597 +15
- Misses 9823 9825 +2
- Partials 602 605 +3 ☔ View full report in Codecov by Sentry. |
NickPhura
changed the title
NickPhura
commented
Aug 21, 2024
|
mauberti-bc
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-600
Description of Changes
Keycloak login infinite loop
automaticSilentRenewflag in the authConfig. This is on by default, but declaring to make it more visible.Console log size
Add new transport to winston logger to write logs to file(s)
Add new env vars for managing the log settings of the file transport
Add PVC config to api deploy yaml (for storing logs)
Other
Testing Notes
Tested this by logging into SIMS in 2 different tabs, and then logging out of one of the tabs.
When the other tab tries to refresh the token, it fails, because the token has already been revoked, and immediately redirects the user to the home page. Watched it happen live, and it all happens quickly and without any weird UI interactions or anything.