SIMSBIOHUB-562: Export Survey Data #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickPhura
added
the
Early Feedback Welcome
|
Openshift URLs for the PR Deployment: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1273 +/- ##
==========================================
+ Coverage 48.28% 48.57% +0.28%
==========================================
Files 763 771 +8
Lines 20465 20704 +239
Branches 3124 3135 +11
==========================================
+ Hits 9882 10056 +174
- Misses 10431 10496 +65
Partials 152 152 ☔ View full report in Codecov by Sentry. |
NickPhura
removed
the
Early Feedback Welcome
…to SIMSBIOHUB-562
…to SIMSBIOHUB-562
|
…to SIMSBIOHUB-562
|
Openshift URLs for the PR Deployment: |
mauberti-bc
reviewed
Sep 11, 2024
mauberti-bc
reviewed
Sep 11, 2024
|
Added some unit tests |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-562
Description of Changes
API
New endpoint that fetches and uploads survey data to s3, and returns a pre-signed url to download it.
APP
New dialog (under survey settings dropdown button) that allows users to execute an export. Currently restricted to project coordinators and collaborators (and system/data admins).
Testing Notes
Pre-req: S3 credentials in
.envFrom the settings button at the top of the survey page, clicking export pops a dialogue, which lets you choose which data to export. Data is exported to a zip file in S3, and immediately downloaded to the users local machine.
To Do
API
Currently the export only supports survey metadata, observations (which both just make a very basic select query, and leave the response as json), and telemetry (which returns the same data as the summary telemetry page).
API - Tests
APP
The dialogue is fairly basic, with no loading bars, etc, for longer exports. It also just auto-downloads the file, which is maybe not what we want if its large. Might be better to just show a link, and let the user trigger it in their browser separately.
Note
Export button is in the dropdown on the survey page.
