SIMSBIOHUB-275: Remove Project Coordinator from SIMS

[curtisupshall]

Links to Jira Tickets

• https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-275

Description of Changes

• Removes any Project Coordinator UI for creating, editing or viewing projects
• Removes any reference to Project Coordinator in the frontend and backend codebase
• Adds a migration that makes project coordinator fields optional, retaining any existing project coordinator data.

Testing Notes (for local environment)

1. On branch dev, create one or more projects.
2. Check out the SIMSBIOHUB-275 branch and run make web to run the new migration.
3. Upon compiling the project, you should be able to:

• View an existing project + participants
• Edit an existing project
• Create a new project
• View a survey + participants
• Add participants to a project
• Add participants to a survey

4. For the projects created before running the migration, their participant data in the project table should still exist.

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1104-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1104-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1104

[NickPhura]

Looks good.

A few tests on front and back end that are referencing project coordinator still.

[codecov]

Codecov Report

Merging #1104 (50eef24) into dev (df7d0cb) will decrease coverage by 14.81%.
The diff coverage is 14.28%.

@@             Coverage Diff             @@
##              dev    #1104       +/-   ##
===========================================
- Coverage   78.11%   63.30%   -14.81%     
===========================================
  Files         231      531      +300     
  Lines        9090    15786     +6696     
  Branches     1338     2445     +1107     
===========================================
+ Hits         7101     9994     +2893     
- Misses       1603     5107     +3504     
- Partials      386      685      +299     

Files	Coverage Δ
api/src/models/project-create.ts	66.66% <ø> (-13.34%)	⬇️
api/src/models/project-update.ts	100.00% <ø> (ø)
api/src/models/project-view.ts	100.00% <ø> (ø)
api/src/models/survey-view.ts	83.33% <ø> (ø)
api/src/openapi/schemas/project.ts	100.00% <ø> (ø)
api/src/paths/project/list.ts	96.29% <ø> (ø)
...rojectId}/participants/{projectParticipationId}.ts	93.65% <ø> (ø)
api/src/paths/project/{projectId}/update.ts	91.22% <ø> (-0.16%)	⬇️
api/src/paths/project/{projectId}/view.ts	95.65% <ø> (ø)
...c/repositories/project-participation-repository.ts	74.28% <ø> (ø)
... and 13 more

... and 292 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[JeremyQuartech]

I may be misunderstanding the changes a bit here, but just clarifying... When creating a project, under managing team members, Coordinator is still meant to be an option right? So do these changes simply remove the ability to add metadata associated with the coordinator?

[curtisupshall]

I may be misunderstanding the changes a bit here, but just clarifying... When creating a project, under managing team members, Coordinator is still meant to be an option right? So do these changes simply remove the ability to add metadata associated with the coordinator?

@JeremyQuartech That is essentially it, yeah. Project team members did not historically have roles like "Coordinator", so projects has specific metadata (Project Coordinator) to store basic info for the primary contact for the project. Since we now have the Coordinator team member role, this information is pretty much unneeded.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[al-rosenthal]

ran this locally and followed your instructions. It is working as expected 🐶