Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-287: User Access Request #1103

Merged
merged 9 commits into from
Oct 5, 2023
Merged

SIMSBIOHUB-287: User Access Request #1103

merged 9 commits into from
Oct 5, 2023

Conversation

al-rosenthal
Copy link
Contributor

Links to Jira Tickets

SIMSBIOHUB-287

Description of Changes

  • Updated create access request to place email and display name in the correct fields
  • Updated dev users that were affected by issue

Testing Notes

  • Create a test BCeID
  • Login to SIMS with your test BCeID and request access
  • Login as admin user and approve the request
  • Edit a project
  • Open the Manage Team members autocomplete and see that the new user display name and email are consistent with other seed users

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #1103 (aed7c5b) into dev (23374a8) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##              dev    #1103   +/-   ##
=======================================
  Coverage   63.28%   63.29%           
=======================================
  Files         531      531           
  Lines       15777    15776    -1     
  Branches     2438     2437    -1     
=======================================
  Hits         9985     9985           
+ Misses       5106     5105    -1     
  Partials      686      686           
Files Coverage Δ
...repositories/administrative-activity-repository.ts 94.73% <ø> (ø)
...pi/src/services/administrative-activity-service.ts 100.00% <100.00%> (ø)
app/src/hooks/api/useAdminApi.ts 80.76% <ø> (+2.99%) ⬆️
app/src/hooks/useKeycloakWrapper.tsx 70.58% <ø> (ø)
api/src/paths/administrative-activity.ts 88.37% <66.66%> (ø)
app/src/features/admin/users/AccessRequestList.tsx 75.55% <50.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! I tested this in Openshift and it works as expected.

One minor bug that you may wish to address in this PR: when you submit your Access Request and are sent back to the home page, the home page doesn't show that you have a pending Access Request until you reload the page. We should peform a refresh of the user's pending access requests when they are sent ot the home page.

@NickPhura
Copy link
Collaborator

nit: can you update the params/doc for the getAdministrativeActivityStanding function in administrative-activity-service.ts. I think the param still says userIdentifier, rather than userGuid.

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@al-rosenthal al-rosenthal merged commit 3acdff4 into dev Oct 5, 2023
22 of 36 checks passed
@al-rosenthal al-rosenthal deleted the SIMSBIOHUB-287 branch October 5, 2023 23:56
KjartanE pushed a commit that referenced this pull request Oct 6, 2023
Fixed issues with users requesting access to the system

---------

Co-authored-by: Nick Phura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants