-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMSBIOHUB-287: User Access Request #1103
Conversation
Openshift URLs for the PR Deployment: |
Codecov Report
@@ Coverage Diff @@
## dev #1103 +/- ##
=======================================
Coverage 63.28% 63.29%
=======================================
Files 531 531
Lines 15777 15776 -1
Branches 2438 2437 -1
=======================================
Hits 9985 9985
+ Misses 5106 5105 -1
Partials 686 686
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good! I tested this in Openshift and it works as expected.
One minor bug that you may wish to address in this PR: when you submit your Access Request and are sent back to the home page, the home page doesn't show that you have a pending Access Request until you reload the page. We should peform a refresh of the user's pending access requests when they are sent ot the home page.
nit: can you update the params/doc for the |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Fixed issues with users requesting access to the system --------- Co-authored-by: Nick Phura <[email protected]>
Links to Jira Tickets
SIMSBIOHUB-287
Description of Changes
Testing Notes