Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIMSBIOHUB-286: Upload Telemetry Files on Device Creation #1102

Merged
merged 62 commits into from
Sep 29, 2023
Merged

SIMSBIOHUB-286: Upload Telemetry Files on Device Creation #1102

merged 62 commits into from
Sep 29, 2023

Conversation

JeremyQuartech
Copy link
Contributor

Links to Jira Tickets

Description of Changes

  • Adds option to attach a .keyx or .cfg file during new telemetry device creation
  • 'keyx' upload section conditionally renders when Vectronic manufacturer is selected
  • 'cfg' upload section conditionally renders when Lotek manufacturer is selected

@JeremyQuartech
Added method to BctwService for keyX file uploads
78d0095
@JeremyQuartech
Merge branch 'dev' into SIMSBIOHUB-263
063af6e
@JeremyQuartech
WIP: Attachment service and repo functions for keyx files
ce9c9c0
@JeremyQuartech
Added survey_attachment_keyx table
e46e75b
@JeremyQuartech
Added attachment-repo methods to insert and update keyx references
22b4323
@JeremyQuartech
Added attachment-keyx-service and modified file object type in BctwSe…
be69edf 
…rvice
@JeremyQuartech
Updated api routes for file processing
daafac9
@JeremyQuartech
Various bug fixes, implemented ui changes for uploads
cc7b09e
@JeremyQuartech
Added notes where improvements can likely be made still.
9f1320a
@JeremyQuartech
Merge branch 'dev' into SIMSBIOHUB-263
79b0b12
@JeremyQuartech
Renamed process endpoint and added stub schema
b524858
@JeremyQuartech
renamed process endpoint to /processKeyx
57e56d5
@JeremyQuartech
revert name changes
02f37dd
@JeremyQuartech
Addressed various PR comments
e451dac
@JeremyQuartech
Extracted keyx detection to file-utils to reduce complexity of upload()
9fb59f9
@JeremyQuartech
Add unit tests for /survey/process
fdd8b45
@JeremyQuartech
Added basic keyx specific upload dialog to survey documents
b40fe5c
@JeremyQuartech
updated Bctw Service unit tests
ef710d1
@JeremyQuartech
Removed /process endpoint
c2bd027
@JeremyQuartech
Added keyx specific upload endpoint
573312e
@JeremyQuartech
Added keyx response schema and error handling to bcwt service
0a9f0e0
@JeremyQuartech
Removed keyx attachment table migration
72e531c
@JeremyQuartech
Added zip file validation
9946b6a
@JeremyQuartech
WIP: displaying errors in keyx uploader
5397ee6
@JeremyQuartech
Added error handling for BCTW api connection refusal
4a73169
@JeremyQuartech
Disabled error details by default
f663c77
@JeremyQuartech
Reverted attachment-repo changes
98323d7
@JeremyQuartech
Removed dead cod
57cb457
@JeremyQuartech
Merge branch 'dev' into SIMSBIOHUB-263
645660d
@JeremyQuartech
Updated BctwService tests
fa75116
@JeremyQuartech JeremyQuartech marked this pull request as ready for review September 27, 2023 20:43
@github-actions
Copy link

Openshift URLs for the PR Deployment:

@JeremyQuartech JeremyQuartech removed the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Sep 27, 2023
curtisupshall
curtisupshall previously approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to my eyes :^)

app/src/features/surveys/view/survey-animals/TelemetryDeviceForm.tsx Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

GrahamS-Quartech
GrahamS-Quartech approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@GrahamS-Quartech GrahamS-Quartech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

curtisupshall
curtisupshall approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

api/src/services/bctw-service.ts Show resolved Hide resolved
app/src/features/surveys/view/SurveyAnimals.tsx Show resolved Hide resolved
@JeremyQuartech JeremyQuartech merged commit 083cb23 into dev Sep 29, 2023
19 of 20 checks passed
al-rosenthal
al-rosenthal approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NickPhura NickPhura deleted the SIMSBIOHUB-286 branch October 13, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamS-Quartech GrahamS-Quartech GrahamS-Quartech approved these changes

@curtisupshall curtisupshall curtisupshall approved these changes

@al-rosenthal al-rosenthal al-rosenthal approved these changes

@NickPhura NickPhura Awaiting requested review from NickPhura

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JeremyQuartech @NickPhura @al-rosenthal @curtisupshall @GrahamS-Quartech