Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-259: General UI Fixes / Clean-up #1088

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Conversation

jeznorth
Copy link
Contributor

Links to Jira Tickets

  • SIMSBIOHUB-259

Description of Changes

  • Cleaning up the front-end / polish
  • Updating language

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #1088 (9cb7701) into dev (5d80722) will increase coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev    #1088      +/-   ##
==========================================
+ Coverage   64.56%   64.64%   +0.07%     
==========================================
  Files         458      458              
  Lines       13940    13923      -17     
  Branches     2191     2190       -1     
==========================================
  Hits         9000     9000              
+ Misses       4383     4366      -17     
  Partials      557      557              
Files Changed Coverage Δ
app/src/features/surveys/CreateSurveyPage.tsx 2.98% <ø> (ø)
app/src/features/surveys/components/BlockForm.tsx 50.00% <ø> (ø)
...res/surveys/components/CreateSurveyBlockDialog.tsx 20.00% <ø> (+11.66%) ⬆️
...tures/surveys/components/EditSurveyBlockDialog.tsx 12.50% <ø> (+6.94%) ⬆️
...features/surveys/components/SurveyBlockSection.tsx 11.11% <0.00%> (ø)
...src/features/surveys/components/SurveyUserForm.tsx 4.34% <ø> (ø)
app/src/features/surveys/edit/EditSurveyForm.tsx 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
13.6% 13.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@al-rosenthal al-rosenthal merged commit 53cc39b into dev Sep 11, 2023
18 of 20 checks passed
@al-rosenthal al-rosenthal deleted the SIMSBIOHUB-259-UI-Fixes branch September 11, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants