-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SISMBIOHUB-259: Survey Block #1085
Conversation
Openshift URLs for the PR Deployment: |
Codecov Report
@@ Coverage Diff @@
## dev #1085 +/- ##
==========================================
- Coverage 64.73% 64.56% -0.18%
==========================================
Files 452 458 +6
Lines 13818 13940 +122
Branches 2179 2191 +12
==========================================
+ Hits 8945 9000 +55
- Misses 4320 4383 +63
- Partials 553 557 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Openshift URLs for the PR Deployment: |
app/src/features/surveys/components/CreateSurveyBlockDialog.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple notes from manually testing:
- The
<Card>
element used to display each survey block should use thevariant='outlined'
prop. - Clicking the
<Card>
shouldn't open the context menu - only the button within the card should open it. - The positioning of the context menu is a bit off; Use these props on the
<Menu>
:
anchorOrigin={{
vertical: 'top',
horizontal: 'right'
}}
transformOrigin={{
vertical: 'top',
horizontal: 'right'
}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐈 ran locally, worked as intended
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌵
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Openshift; Code looks good and works well!
Links to Jira Tickets
SIMSBIOHUB-259
SIMSBIOHUB-260
SIMSBIOHUB-261
Description of Changes
Testing Notes