Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SISMBIOHUB-259: Survey Block #1085

Merged
merged 21 commits into from
Sep 8, 2023
Merged

SISMBIOHUB-259: Survey Block #1085

merged 21 commits into from
Sep 8, 2023

Conversation

al-rosenthal
Copy link
Contributor

@al-rosenthal al-rosenthal commented Sep 5, 2023

Links to Jira Tickets

SIMSBIOHUB-259
SIMSBIOHUB-260
SIMSBIOHUB-261

Description of Changes

  • New service and repository added to handle survey block actions
  • Added UI for survey block create/ edit survey pages

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #1085 (32bf987) into dev (df258a0) will decrease coverage by 0.18%.
The diff coverage is 45.08%.

@@            Coverage Diff             @@
##              dev    #1085      +/-   ##
==========================================
- Coverage   64.73%   64.56%   -0.18%     
==========================================
  Files         452      458       +6     
  Lines       13818    13940     +122     
  Branches     2179     2191      +12     
==========================================
+ Hits         8945     9000      +55     
- Misses       4320     4383      +63     
- Partials      553      557       +4     
Files Changed Coverage Δ
api/src/models/survey-create.ts 83.92% <0.00%> (-1.53%) ⬇️
api/src/models/survey-view.ts 86.76% <ø> (ø)
api/src/paths/project/{projectId}/survey/create.ts 96.15% <ø> (ø)
...hs/project/{projectId}/survey/{surveyId}/update.ts 96.29% <ø> (ø)
...roject/{projectId}/survey/{surveyId}/update/get.ts 84.37% <ø> (ø)
app/src/features/surveys/CreateSurveyPage.tsx 2.98% <ø> (ø)
app/src/features/surveys/edit/EditSurveyForm.tsx 0.00% <ø> (ø)
...tures/surveys/components/EditSurveyBlockDialog.tsx 5.55% <5.55%> (ø)
...res/surveys/components/CreateSurveyBlockDialog.tsx 8.33% <8.33%> (ø)
...features/surveys/components/SurveyBlockSection.tsx 11.11% <11.11%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@al-rosenthal al-rosenthal marked this pull request as ready for review September 6, 2023 21:46
@curtisupshall curtisupshall self-assigned this Sep 6, 2023
api/src/repositories/survey-block-repository.ts Outdated Show resolved Hide resolved
api/src/services/survey-block-service.ts Outdated Show resolved Hide resolved
api/src/services/survey-block-service.ts Outdated Show resolved Hide resolved
api/src/services/survey-service.ts Outdated Show resolved Hide resolved
app/src/features/surveys/CreateSurveyPage.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple notes from manually testing:

  1. The <Card> element used to display each survey block should use the variant='outlined' prop.
  2. Clicking the <Card> shouldn't open the context menu - only the button within the card should open it.
  3. The positioning of the context menu is a bit off; Use these props on the <Menu>:
anchorOrigin={{
  vertical: 'top',
  horizontal: 'right'
}}
transformOrigin={{
  vertical: 'top',
  horizontal: 'right'
}}

KjartanE
KjartanE previously approved these changes Sep 8, 2023
Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈 ran locally, worked as intended

@KjartanE KjartanE self-assigned this Sep 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.3% 3.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌵

Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Openshift; Code looks good and works well!

@al-rosenthal al-rosenthal merged commit 5d80722 into dev Sep 8, 2023
17 of 20 checks passed
@al-rosenthal al-rosenthal deleted the SIMSBIOHUB-259 branch September 8, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants