Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-262: Create Survey Blocks table #1081

Merged
merged 10 commits into from
Aug 31, 2023
Merged

SIMSBIOHUB-262: Create Survey Blocks table #1081

merged 10 commits into from
Aug 31, 2023

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Aug 30, 2023

Links to Jira Tickets

Description of Changes

  • Creates new tables:
    • survey_block , which stores blocks for surveys
    • survey_stratrum, which stores stratum for surveys (in particular, those that have "Stratum" as a site selection strategy)
    • site_strategy, which stores a codeset of survey site selection strategies; at the moment, those are Random, Stratified, and Systematic.
    • survey_site_strategy, which stores the particular strategies associated with a given survey
  • Ammends the survey deletion procedure to delete blocks as well as stratum records upon survey deletion

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #1081 (56d6152) into dev (ec42e38) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1081   +/-   ##
=======================================
  Coverage   64.34%   64.34%           
=======================================
  Files         440      440           
  Lines       13510    13510           
  Branches     2150     2150           
=======================================
  Hits         8693     8693           
  Misses       4287     4287           
  Partials      530      530           
Files Changed Coverage Δ
app/src/features/projects/view/ProjectDetails.tsx 33.33% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@curtisupshall curtisupshall reopened this Aug 30, 2023
al-rosenthal
al-rosenthal previously approved these changes Aug 31, 2023
Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 👀

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥦

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@curtisupshall curtisupshall merged commit 68a6d84 into dev Aug 31, 2023
20 checks passed
KjartanE pushed a commit that referenced this pull request Sep 5, 2023
* Creates new tables: survey_block, survey_stratrum, site_strategy, survey_site_strategy
* Amends the survey deletion procedure to delete blocks as well as stratum records upon survey deletion
@curtisupshall curtisupshall deleted the SIMSBIOHUB-262 branch September 27, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants