-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: push notifications #1389
feat: push notifications #1389
Conversation
eb039ac
to
66b6081
Compare
d6f80b7
to
3665acc
Compare
@jamshale Is this one ready for review? If not are you able to move it to "Draft", otherwise we can remove the "do not merge" label and review it. |
Awesome! I did some work recently and want to go over it and update the description. I should have it ready for review today. |
can you please make it "off" by default. We will start using internally, and once we have fully tested we can change to default "on" |
Yes will do. |
1df3c29
to
9c6d4a5
Compare
@jleach Ok, I would like to open this for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small things, overall seems fairly sturdy. I'll check out the branch and test locally later and see if I find any other issues.
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
Signed-off-by: Jamie Hale <[email protected]>
Signed-off-by: Jamie Hale <[email protected]>
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
I can give access to my firebase account if anyone wants to test with the mediator plugin. Or just send the service account file. It's just on free tier, so it's not much of a concern giving it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @jleach @wadeking98 @cvarjao how do we feel about merging this?
Adds firebase push notification capability when using a mediator with the configured firebase plugin.
Things of note:
Here is some sequence diagrams of current features: https://hackmd.io/@NQjeSsXCR3Cmgs2Lr-M8ow/SJCS87BC2
Here is a demo video of current status:
Mediator doesn't support firebase:
push-notifications-no-mediator.webm
Mediator does support firebase:
push-notifications-with-mediator-plugin.webm
There are 2 new env variables:
** Currently it will ask for push notifications permission but send a blank token. It will be defaulted to off and will need to be turned on via development screen before receiving push notifications. **
I would like to write some unit tests. I had some earlier but deleted them after the modal broke the required mocks.