-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New OpenPGP Specification #525
base: master
Are you sure you want to change the base?
New OpenPGP Specification #525
Conversation
- Ed25519Legacy with v4 keys/signatures - classes for "native" (octet array) key material - parsing v5/v6 packets (public key, unlocked secret key, signature) - basic verification of v6 signatures - test vectors from crypto-refresh draft
Wow @roughconsensusandrunningcode this looks fairly comprehensive on first glance! Two initial questions for you:
|
Hello, sorry for the late answer
v5 pubkeys packet format is identical to v6 (the only difference is the first octet in fingerprint computation). v5 seckeys (not yet supported by this PR) are very similar but not identical to v6. v5 signatures are identical to v4 in the packet format but include additional metadata in hash computation.
I'm already working on KeyRingGenerator and PgpSecretKey classes. |
* Unprotected v6 keys does not use the two-octets checksum https://www.ietf.org/archive/id/draft-ietf-openpgp-crypto-refresh-13.html#table-2 * In DoCopyWithNewPassword rewrite Checksum using SHA-1 instead of the deprecated UsageChecksum (MalleableCFB) * Some code deduplication and reorganization
This PR adds a partial support for the new OpenPGP Specification ("Crypto-Refresh" draft, currently in RFC Editor publication queue). Ported from bc-java when possible.
TODO: