Horizontal bars not rendering in chrome 60+ or IE

bbimber · Aug 9, 2017 · 1d58bec · 1d58bec
1 parent ebcc76f
commit 1d58bec
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/...urces/org/broadinstitute/gatk/tools/walkers/variantqc/templates/assets/js/summaryTable.js b/...urces/org/broadinstitute/gatk/tools/walkers/variantqc/templates/assets/js/summaryTable.js
@@ -52,12 +52,11 @@ function generateTableHtml(config){
                     percentage = ((parseFloat(val) - (column.dmin || 0)) / (column.dmax - (column.dmin || 0))) * 100;
                 }
 
-                if (val < column.flagBelow || val > column.flagAbove){
-                    html += '<td ' + (showBar ? 'class="data-coloured-flagged ' + column.colId + '_' + column.name + ' "' : '') + '><div class="wrapper">' + (showBar ? '<span class="bar" style="width:' + percentage + '%;"></span>' : '') + '<span class="val">' + formattedVal + '</span></div></td>';
-                } else {
-                    html += '<td ' + (showBar ? 'class="data-coloured ' + column.colId + '_' + column.name + ' "' : '') + '><div class="wrapper">' + (showBar ? '<span class="bar" style="width:' + percentage + '%;"></span>' : '') + '<span class="val">' + formattedVal + '</span></div></td>';
-                }
+                var doFlag = val < column.flagBelow || val > column.flagAbove;
 
+                // see this issue for the reason behind the manual height:
+                // https://github.com/ewels/MultiQC/issues/545
+                html += '<td style="height: 1px;" ' + (showBar ? 'class="data-coloured' + (doFlag ? '-flagged ' : ' ') + column.colId + '_' + column.name + ' "' : '') + '><div class="wrapper">' + (showBar ? '<span class="bar" style="width:' + percentage + '%;"></span>' : '') + '<span class="val">' + formattedVal + '</span></div></td>';
             }
             else {
                 html += '<td>ND</td>';