Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more configuration options to the overview waveform, make it possible to turn on or off the axes #124

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ziggythehamster
Copy link
Contributor

You can now configure:

  • The highlight rectangle padding (we use this because we make our overview bar smaller)
  • The highlight rectangle opacity
  • The overview axis colors

@ziggythehamster ziggythehamster force-pushed the overview-waveform-options branch 4 times, most recently from 0a9a3ff to ab0a17b Compare July 2, 2015 17:32
@ziggythehamster
Copy link
Contributor Author

This now goes against latest master :)

@ziggythehamster
Copy link
Contributor Author

@oncletom Any chance of getting this reviewed? :)

@thom4parisot
Copy link
Contributor

Hey!

Thanks for the proposals, they are valuable options!

The list of options is now very long, and I wonder how effective it is for newcomers and peaks users.

In issue #53, I propose to use the same config objects but to pass them to the views directly in order to control them. Next step would be to use the same objects for both views (zoom and overview) and to affect their layout only via configuration. Peaks responsibility would then be to synchronise/handle/dispatch events to the views/media player.

@ziggythehamster
Copy link
Contributor Author

Looking at that API, I'm not sure that it covers the same things. This PR gives you some more knobs to turn to customize the appearance of the waveforms (ideally, all of the constants are configurable, but we haven't needed to change everything). I'm all for abstracting that away, I'm just not entirely sure how. In an ideal world, it's controllable via CSS - but I realize you can't do that because we're talking about a canvas.

@chrisn chrisn force-pushed the master branch 2 times, most recently from 0e6b861 to b8c6557 Compare August 10, 2017 17:55
@chrisn chrisn force-pushed the master branch 2 times, most recently from 38e7da9 to bb8dbce Compare August 22, 2017 21:01
@chrisn chrisn force-pushed the master branch 3 times, most recently from d73e5c8 to c85041a Compare June 26, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants