Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Attribute #98

Merged
merged 9 commits into from
Aug 17, 2023
Merged

Deprecate Attribute #98

merged 9 commits into from
Aug 17, 2023

Conversation

bbatsche
Copy link
Owner

Deprecate calls to "attribute" assertions and replace with "property" (where applicable)
Other fixes and cleanup for PHPUnit 10 compatibility
Update dev support files

@bbatsche
Copy link
Owner Author

Resolves issue #98

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #98 (005f96e) into master (e7ea637) will decrease coverage by 0.29%.
The diff coverage is 83.48%.

@@             Coverage Diff              @@
##             master      #98      +/-   ##
============================================
- Coverage     94.94%   94.66%   -0.29%     
- Complexity      239      257      +18     
============================================
  Files             9       10       +1     
  Lines           534      618      +84     
============================================
+ Hits            507      585      +78     
- Misses           27       33       +6     
Files Changed Coverage Δ
src/API/File.php 97.64% <ø> (+0.21%) ⬆️
src/API/Method.php 100.00% <ø> (ø)
src/API/Assert.php 41.66% <41.66%> (ø)
src/Constraint/Factory.php 92.02% <80.95%> (+4.02%) ⬆️
src/API/Value.php 92.99% <85.00%> (-0.63%) ⬇️
src/API/Base.php 100.00% <100.00%> (+1.08%) ⬆️
src/API/Property.php 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@bbatsche bbatsche linked an issue Aug 17, 2023 that may be closed by this pull request
@bbatsche
Copy link
Owner Author

Coverage hit is negligible, merging anyway

@bbatsche bbatsche merged commit 049e799 into master Aug 17, 2023
10 of 12 checks passed
@bbatsche bbatsche deleted the deprecate-attribute branch August 17, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Deprecate & Replace “Attribute”
1 participant