Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove BUILD rules for building our release artifact #130

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .bazelci/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ rolling: &rolling
ubuntu2004: &ubuntu
platform: ubuntu2004
<<: *default_tests
build_targets:
- "//distro:distro"
- "//distro:relnotes"

macos: &macos
platform: macos
Expand Down Expand Up @@ -74,6 +71,3 @@ tasks:
<<: *rolling
build_flags:
- "--enable_bzlmod"
build_targets:
- "//distro:distro"
- "//distro:relnotes"
14 changes: 0 additions & 14 deletions BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -48,17 +48,3 @@ exports_files(
]),
visibility = ["//visibility:public"],
)

filegroup(
name = "standard_package",
srcs = glob([
"*.bzl",
"*.md",
]) + [
"MODULE.bazel",
"BUILD",
"LICENSE",
"WORKSPACE.bzlmod",
],
visibility = ["//distro:__pkg__"],
)
74 changes: 0 additions & 74 deletions distro/BUILD

This file was deleted.

59 changes: 0 additions & 59 deletions distro/check_build.sh

This file was deleted.

24 changes: 2 additions & 22 deletions doc_build/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -26,26 +26,6 @@ load("//:version.bzl", "version")

package(default_package_metadata = ["//:license", "//:package_info"])

filegroup(
name = "standard_package",
srcs = [
"BUILD",
] + glob([
"*.bzl",
"*.py",
]),
visibility = ["//distro:__pkg__"],
)

exports_files(
glob([
"*.bzl",
]),
visibility = [
"//distro:__pkg__",
],
)

# pairs of rule name and the source file to get it from
# Must put macro wrapped rules after their wrapper
# buildifier: leave-alone, do not sort
Expand Down Expand Up @@ -91,8 +71,8 @@ bzl_library(
name = "lib_of_everything",
srcs = [
"//:version.bzl",
"//rules:standard_package",
"//rules_gathering:standard_package",
"//rules:bzl",
"//rules_gathering:bzl",
],
visibility = ["//visibility:public"],
)
Expand Down
3 changes: 0 additions & 3 deletions examples/manifest/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ android_library(
srcs = [
"license_display.sh",
],
data = [
"@rules_license//distro:distro",
],
)

# This captures how the application would be built. The dependencies of this
Expand Down
5 changes: 0 additions & 5 deletions licenses/generic/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,6 @@ package(

licenses(["notice"])

filegroup(
name = "standard_package",
srcs = ["BUILD"],
)

# "none" should be used for packages which are distributed with no license of
# any kind. You can use this no-op license as a positive indication that the
# code's license terms were reviewed, so that linters will not flag it later as
Expand Down
5 changes: 0 additions & 5 deletions licenses/spdx/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,6 @@ package(

licenses(["notice"])

filegroup(
name = "standard_package",
srcs = ["BUILD"],
)

license_kind(
name = "0BSD",
conditions = [],
Expand Down
8 changes: 3 additions & 5 deletions rules/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,10 @@ trace(
visibility = ["//visibility:public"],
)

# TODO(alexeagle): use gazelle to replace all these with bzl_library
filegroup(
name = "standard_package",
srcs = glob([
"**/BUILD",
"**/*.bzl",
]),
name = "bzl",
srcs = glob(["**/*.bzl"]),
)

# Do not create a bzl_library(). That would create a dependency loop back
Expand Down
5 changes: 0 additions & 5 deletions rules/private/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,6 @@ package(

licenses(["notice"])

filegroup(
name = "standard_package",
srcs = glob(["**"]),
)

# Do not create a bzl_library(). That would create a dependency loop back
# to bazel-skylib. We export the .bzl files to the documentation maker.
exports_files(
Expand Down
5 changes: 3 additions & 2 deletions rules_gathering/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,10 @@ package(
default_visibility = ["//visibility:public"],
)

# TODO(alexeagle): use gazelle to replace all these with bzl_library
filegroup(
name = "standard_package",
srcs = glob(["**"]),
name = "bzl",
srcs = glob(["*.bzl"]),
)

# Do not create a bzl_library(). That would create a dependency loop back
Expand Down
5 changes: 0 additions & 5 deletions sample_reports/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ package(

licenses(["notice"])

filegroup(
name = "standard_package",
srcs = glob(["**"]),
)

# Do not create a bzl_library(). That would create a dependency loop back
# to bazel-skylib. We export the .bzl files to the documentation maker.
exports_files(
Expand Down
6 changes: 0 additions & 6 deletions tools/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,6 @@ package(

licenses(["notice"])

filegroup(
name = "standard_package",
srcs = glob(["**"]),
visibility = ["//distro:__pkg__"],
)

exports_files(["diff_test.sh"])

py_binary(
Expand Down
6 changes: 0 additions & 6 deletions tools/test_helpers.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,6 @@ def golden_cmd_test(
"""
actual = name + ".output"

# There are some cases where tools are provided and exec_tools are provided.
# Specifying both in the same genrule, confuses the host vs exec rules,
# which prevents python3 from execution.
if tools and exec_tools:
fail("Only set one: tools or exec_tools. " +
"Setting both confuses python execution mode (host vs exec).")
native.genrule(
name = name + "_output",
srcs = srcs,
Expand Down