Allow analysis tests to support for_dependency_resolution on the target_under_test
#553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bocete
requested review from
brandjon,
tetromino,
comius,
hvadehra and
c-mita
as code owners
|
I suspect this is blocked on a blaze release? Dormant deps are still experimental, and the CI tests are failing because of syntax that's made available via experimental flags. @lberki to comment |
|
I don't think it's technically blocked on a Blaze release, only its use internally is for reasons complicated and irrelevant to Bazel. So as long as the code is fine, feel free to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute is necessary to analysis test dormant targets. It's hard to assert anything useful without materializing what's behind the
target_under_test, and that requires settingfor_dependency_resolutionon thetarget_under_test.See https://bazel.build/rules/lib/toplevel/attr#label.for_dependency_resolution for more info on this attribute. It's a new bazel feature.