tarball uses hermetic coreutils #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
reviewed
Jun 24, 2024
rickvanprim
force-pushed
the
tarball_hermetic_coreutils
branch
from
a48f58a
to
21ba7de
Compare
thesayyn
approved these changes
Jun 25, 2024
|
@rickvanprim there seems to be some conflicts? can you resolve those? |
rickvanprim
force-pushed
the
tarball_hermetic_coreutils
branch
from
21ba7de
to
70a22db
Compare
Done. That was weird, the merge conflict was in |
|
Ah the file got renamed, that makes sense 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
tarball.sh.tplto use the hermetic coreutils. I opted to match the existing script form of supplying a variable for the executable instead of the newerimage.sh.tplform of modifyingPATHand assuming the binary name (particularly as updatingtardoesn't seem like it would work as the binary name is different between Windows and Unix). If you'd prefer I modifyPATHto findcoreutils, I could do that instead.