Remove build_tools_version and api_level.
#571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows `android_sdk_repository` to select these values automatically.
ahumesky
requested review from
c-parsons,
cheister,
jin and
shs96c
as code owners
|
The zipalign breakage is a separate known issue unrelated to this PR (it also happens in other CI builds using RBE, for example android/testing-samples#387). I think we should get this PR merged while we look at the zipalign thing. |
|
Closing as #593 has been merged to remove build_tools_version. If we need to remove api_level as well, happy to merge another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
android_sdk_repositoryto select these values automatically.See bazelbuild/bazel#13409