Fix for #1239 #1264
Fix for #1239 #1264
Conversation
|
@jsharpe Please take a final look. |
MODULE.bazel
Outdated
| @@ -10,12 +10,12 @@ bazel_dep(name = "bazel_features", version = "1.15.0") | |||
| bazel_dep(name = "bazel_skylib", version = "1.3.0") | |||
| bazel_dep(name = "platforms", version = "0.0.5") | |||
| bazel_dep(name = "rules_python", version = "0.23.1") | |||
| bazel_dep(name = "rules_cc", version = "0.0.9") | |||
There was a problem hiding this comment.
rules_cc shouldn't be required at all - I'll put in a separate PR to rectify this
There was a problem hiding this comment.
Ah rules_cc as a dev_dependency is only present to satisfy the rbe configuration - that package needs some work to fix it up properly..
There was a problem hiding this comment.
@jsharpe without it I have the following error on Windows:
The repository '@@[unknown repo 'rules_cc' requested from @@rules_foreign_cc~~tools~glib_dev]' could not be resolved: No repository visible as '@rules_cc' from repository '@@rules_foreign_cc~~tools~glib_dev'. and referenced by '@@rules_foreign_cc~//toolchains/private:pkgconfig_tool_msvc_build_'
So it was added to fix the error above.
There was a problem hiding this comment.
I know but the solution isn't to start depending on rules_cc. I'm addressing this in #1269 instead.
There was a problem hiding this comment.
Okay, got it.
There was a problem hiding this comment.
I've merged 1269 now so if you remove this files changes from this PR then we can land this fix.
There was a problem hiding this comment.
@jsharpe I removed it.
dmitry-j-mikhin
force-pushed
the
#1239
branch
2 times, most recently
from
0d8a933
to
b6dbaa5
Compare
|
@jsharpe it looks like CI/CD is broken due to missing APR archive file: This has nothing to do with my PR. |
Inspired by foundationrobotics@0bf2b36 But instead of using vulnerable version 1.7.4 with CVE-2023-49582 we use 1.7.5 Check https://downloads.apache.org/apr/CHANGES-APR-1.7
This fix error message like this in case of bzlmod usage: invalid registered toolchain '@rules_foreign_cc//toolchains:preinstalled_nmake_toolchain': No repository visible as '@rules_foreign_cc' from main repository
|
I created a separate PR for the APR issue - #1273 and rebased the current branch onto it to make CI/CD green again. |
Thank you! |
Closes #1239