Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect stubs from dependencies of targets #134

Conversation

chrisirhc
Copy link

@chrisirhc chrisirhc commented Jun 20, 2024

This is a stab at #39 .

Logic mostly sourced from aspect-build/rules_py#235 .
This logic likely requires a recent version of mypy and has only been tested with the latest mypy version (1.10.0).

Main thing this introduces is to make imports of rules_python dependencies available to the mypy via PYTHONPATH. These are site-packages and are supported by mypy. mypy requires that these packages be installed, and not on MYPYPATH.

TODOs:

  • Have not looked into how cache_map is used, I've commented it out, haven't investigated this. I could probably just follow the logic that's in Mypy aspect-build/rules_py#235
  • Clean up the commits
  • Address lint issues caught in CI
  • Add a test for this behavior

@chrisirhc chrisirhc changed the title Detect stubs from dependencies Detect stubs from dependencies of targets Jun 20, 2024
@chrisirhc
Copy link
Author

chrisirhc commented Jun 21, 2024

I believe this is an alternative implementation to #42

@chrisirhc chrisirhc marked this pull request as draft August 13, 2024 04:05
@chrisirhc
Copy link
Author

I likely won't have bandwidth to take this to finish line.

@chrisirhc chrisirhc closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant