Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bzlmod): allow passing build_extra_args in gazelle_override #1648

Merged

Conversation

casuallyhostile
Copy link
Contributor

What type of PR is this?

Fix

What package or component does this PR mostly affect?

bzlmod

What does this PR do? Why is it needed?

When using bzlmod the gazelle_override doesn't support command line arguments to pass to Gazelle.
This PR adds the build_extra_args attribute

Which issues(s) does this PR fix?

Fixes #1647

@fmeum fmeum self-requested a review October 10, 2023 11:52
internal/bzlmod/go_deps.bzl Outdated Show resolved Hide resolved
@casuallyhostile
Copy link
Contributor Author

@fmeum thanks for the blazing fast reply! ❤️

In CI I'm getting

(12:03:11) ERROR: Analysis of target '@test_dep~override//:test' failed; build aborted: Lock file is no longer up-to-date because: The implementation of the extension 'ModuleExtensionId{bzlFileLabel=@gazelle~override//:extensions.bzl, extensionName=go_deps, isolationKey=Optional[test_dep@_~go_deps]}' or one of its transitive .bzl files has changed

Did I do something wrong with bumping the lockfile?

@fmeum
Copy link
Member

fmeum commented Oct 10, 2023

Could you run bazel mod deps in tests/bcr? It does produce a non-empty diff for me.

internal/bzlmod/go_deps.bzl Outdated Show resolved Hide resolved
@fmeum fmeum merged commit d8369a6 into bazel-contrib:master Oct 28, 2023
10 checks passed
@jamesthompson
Copy link

@fmeum Any communications on when this might be pushed up to the bazel central registry as a release from anyone?

@fmeum
Copy link
Member

fmeum commented Nov 7, 2023

We are in the process of preparing the next release: #1656

@casuallyhostile casuallyhostile deleted the aa/bzlmod-build_extra_artgs branch November 7, 2023 08:06
renovate bot referenced this pull request in kreempuff/rules_unreal_engine Nov 8, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) |
http_archive | minor | `v0.33.0` -> `v0.34.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary>

###
[`v0.34.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.34.0)

[Compare
Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.33.0...v0.34.0)

#### What's Changed

- update readme for v0.33.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1627](https://togithub.com/bazelbuild/bazel-gazelle/pull/1627)
- Remove golang.org/x/crypto dep by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1631](https://togithub.com/bazelbuild/bazel-gazelle/pull/1631)
- Fix map_kind with empty rules by
[@&#8203;lbcjbb](https://togithub.com/lbcjbb) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1441](https://togithub.com/bazelbuild/bazel-gazelle/pull/1441)
- fix: add missing bzl_library declaration and dep by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1633](https://togithub.com/bazelbuild/bazel-gazelle/pull/1633)
- chore: add bzl_test to ensure that bzl_library declarations exist by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1634](https://togithub.com/bazelbuild/bazel-gazelle/pull/1634)
- Set runfiles environment variables for Gazelle by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1632](https://togithub.com/bazelbuild/bazel-gazelle/pull/1632)
- address comments from
[#&#8203;1597](https://togithub.com/bazelbuild/bazel-gazelle/issues/1597)
by [@&#8203;shahms](https://togithub.com/shahms) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1628](https://togithub.com/bazelbuild/bazel-gazelle/pull/1628)
- Fix kinds and stmt by [@&#8203;birunts](https://togithub.com/birunts)
in
[https://github.com/bazelbuild/bazel-gazelle/pull/1613](https://togithub.com/bazelbuild/bazel-gazelle/pull/1613)
- Export workspace file in go_repository_config.bzl by
[@&#8203;mortenmj](https://togithub.com/mortenmj) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1641](https://togithub.com/bazelbuild/bazel-gazelle/pull/1641)
- Add github.com/google/gnostic-models to default_gazelle_overrides.bzl
by [@&#8203;mortenmj](https://togithub.com/mortenmj) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1645](https://togithub.com/bazelbuild/bazel-gazelle/pull/1645)
- Support parsing labels that begin '@&#8203;@&#8203;' by
[@&#8203;mark-thm](https://togithub.com/mark-thm) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1651](https://togithub.com/bazelbuild/bazel-gazelle/pull/1651)
- Fix path for google/gnostic-models by
[@&#8203;mortenmj](https://togithub.com/mortenmj) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1652](https://togithub.com/bazelbuild/bazel-gazelle/pull/1652)
- fix(bzlmod): allow passing build_extra_args in gazelle_override by
[@&#8203;casuallyhostile](https://togithub.com/casuallyhostile) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1648](https://togithub.com/bazelbuild/bazel-gazelle/pull/1648)
- prepare release 0.34.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1656](https://togithub.com/bazelbuild/bazel-gazelle/pull/1656)

#### New Contributors

- [@&#8203;casuallyhostile](https://togithub.com/casuallyhostile) made
their first contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1648](https://togithub.com/bazelbuild/bazel-gazelle/pull/1648)

**Full Changelog**:
bazel-contrib/bazel-gazelle@v0.33.0...v0.34.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/kreempuff/rules_unreal_engine).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/bazel-starlib Nov 8, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) |
http_archive | minor | `v0.33.0` -> `v0.34.0` |

---

### Release Notes

<details>
<summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary>

###
[`v0.34.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.34.0)

[Compare
Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.33.0...v0.34.0)

#### What's Changed

- update readme for v0.33.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1627](https://togithub.com/bazelbuild/bazel-gazelle/pull/1627)
- Remove golang.org/x/crypto dep by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1631](https://togithub.com/bazelbuild/bazel-gazelle/pull/1631)
- Fix map_kind with empty rules by
[@&#8203;lbcjbb](https://togithub.com/lbcjbb) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1441](https://togithub.com/bazelbuild/bazel-gazelle/pull/1441)
- fix: add missing bzl_library declaration and dep by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1633](https://togithub.com/bazelbuild/bazel-gazelle/pull/1633)
- chore: add bzl_test to ensure that bzl_library declarations exist by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1634](https://togithub.com/bazelbuild/bazel-gazelle/pull/1634)
- Set runfiles environment variables for Gazelle by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1632](https://togithub.com/bazelbuild/bazel-gazelle/pull/1632)
- address comments from
[#&#8203;1597](https://togithub.com/bazelbuild/bazel-gazelle/issues/1597)
by [@&#8203;shahms](https://togithub.com/shahms) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1628](https://togithub.com/bazelbuild/bazel-gazelle/pull/1628)
- Fix kinds and stmt by [@&#8203;birunts](https://togithub.com/birunts)
in
[https://github.com/bazelbuild/bazel-gazelle/pull/1613](https://togithub.com/bazelbuild/bazel-gazelle/pull/1613)
- Export workspace file in go_repository_config.bzl by
[@&#8203;mortenmj](https://togithub.com/mortenmj) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1641](https://togithub.com/bazelbuild/bazel-gazelle/pull/1641)
- Add github.com/google/gnostic-models to default_gazelle_overrides.bzl
by [@&#8203;mortenmj](https://togithub.com/mortenmj) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1645](https://togithub.com/bazelbuild/bazel-gazelle/pull/1645)
- Support parsing labels that begin '@&#8203;@&#8203;' by
[@&#8203;mark-thm](https://togithub.com/mark-thm) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1651](https://togithub.com/bazelbuild/bazel-gazelle/pull/1651)
- Fix path for google/gnostic-models by
[@&#8203;mortenmj](https://togithub.com/mortenmj) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1652](https://togithub.com/bazelbuild/bazel-gazelle/pull/1652)
- fix(bzlmod): allow passing build_extra_args in gazelle_override by
[@&#8203;casuallyhostile](https://togithub.com/casuallyhostile) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1648](https://togithub.com/bazelbuild/bazel-gazelle/pull/1648)
- prepare release 0.34.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1656](https://togithub.com/bazelbuild/bazel-gazelle/pull/1656)

#### New Contributors

- [@&#8203;casuallyhostile](https://togithub.com/casuallyhostile) made
their first contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1648](https://togithub.com/bazelbuild/bazel-gazelle/pull/1648)

**Full Changelog**:
bazel-contrib/bazel-gazelle@v0.33.0...v0.34.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
alexeagle referenced this pull request in aspect-build/rules_py Nov 14, 2023
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) |
http_archive | minor | `v0.32.0` -> `v0.34.0` |

---

### Release Notes

<details>
<summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary>

###
[`v0.34.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.34.0)

[Compare
Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.33.0...v0.34.0)

#### What's Changed

- update readme for v0.33.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1627](https://togithub.com/bazelbuild/bazel-gazelle/pull/1627)
- Remove golang.org/x/crypto dep by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1631](https://togithub.com/bazelbuild/bazel-gazelle/pull/1631)
- Fix map_kind with empty rules by
[@&#8203;lbcjbb](https://togithub.com/lbcjbb) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1441](https://togithub.com/bazelbuild/bazel-gazelle/pull/1441)
- fix: add missing bzl_library declaration and dep by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1633](https://togithub.com/bazelbuild/bazel-gazelle/pull/1633)
- chore: add bzl_test to ensure that bzl_library declarations exist by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1634](https://togithub.com/bazelbuild/bazel-gazelle/pull/1634)
- Set runfiles environment variables for Gazelle by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1632](https://togithub.com/bazelbuild/bazel-gazelle/pull/1632)
- address comments from
[#&#8203;1597](https://togithub.com/bazelbuild/bazel-gazelle/issues/1597)
by [@&#8203;shahms](https://togithub.com/shahms) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1628](https://togithub.com/bazelbuild/bazel-gazelle/pull/1628)
- Fix kinds and stmt by [@&#8203;birunts](https://togithub.com/birunts)
in
[https://github.com/bazelbuild/bazel-gazelle/pull/1613](https://togithub.com/bazelbuild/bazel-gazelle/pull/1613)
- Export workspace file in go_repository_config.bzl by
[@&#8203;mortenmj](https://togithub.com/mortenmj) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1641](https://togithub.com/bazelbuild/bazel-gazelle/pull/1641)
- Add github.com/google/gnostic-models to default_gazelle_overrides.bzl
by [@&#8203;mortenmj](https://togithub.com/mortenmj) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1645](https://togithub.com/bazelbuild/bazel-gazelle/pull/1645)
- Support parsing labels that begin '@&#8203;@&#8203;' by
[@&#8203;mark-thm](https://togithub.com/mark-thm) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1651](https://togithub.com/bazelbuild/bazel-gazelle/pull/1651)
- Fix path for google/gnostic-models by
[@&#8203;mortenmj](https://togithub.com/mortenmj) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1652](https://togithub.com/bazelbuild/bazel-gazelle/pull/1652)
- fix(bzlmod): allow passing build_extra_args in gazelle_override by
[@&#8203;casuallyhostile](https://togithub.com/casuallyhostile) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1648](https://togithub.com/bazelbuild/bazel-gazelle/pull/1648)
- prepare release 0.34.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1656](https://togithub.com/bazelbuild/bazel-gazelle/pull/1656)

#### New Contributors

- [@&#8203;casuallyhostile](https://togithub.com/casuallyhostile) made
their first contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1648](https://togithub.com/bazelbuild/bazel-gazelle/pull/1648)

**Full Changelog**:
bazel-contrib/bazel-gazelle@v0.33.0...v0.34.0

###
[`v0.33.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.33.0)

[Compare
Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.32.0...v0.33.0)

#### What's Changed

- Generate BUILD files for grpc-gateway by default by
[@&#8203;seh](https://togithub.com/seh) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1578](https://togithub.com/bazelbuild/bazel-gazelle/pull/1578)
- Remove temporary workaround after rules_go 0.41.0 release by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1577](https://togithub.com/bazelbuild/bazel-gazelle/pull/1577)
- bzlmod: Use first host-compatible SDK to bootstrap Gazelle by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1581](https://togithub.com/bazelbuild/bazel-gazelle/pull/1581)
- Update: golang.org/x/exp & golang.org/x/oauth2 deps. by
[@&#8203;sfc-gh-ptabor](https://togithub.com/sfc-gh-ptabor) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1582](https://togithub.com/bazelbuild/bazel-gazelle/pull/1582)
- \[README.rst] Mention kotlin PoC by
[@&#8203;kolloch](https://togithub.com/kolloch) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1590](https://togithub.com/bazelbuild/bazel-gazelle/pull/1590)
- Fix and let `# gazelle:follow` accept a glob by
[@&#8203;shahms](https://togithub.com/shahms) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1596](https://togithub.com/bazelbuild/bazel-gazelle/pull/1596)
- Add support for isolated `go_deps` usages by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1584](https://togithub.com/bazelbuild/bazel-gazelle/pull/1584)
- feat(bzlmod): support archive_override in go_deps by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1559](https://togithub.com/bazelbuild/bazel-gazelle/pull/1559)
- fix: avoid updating `WORKSPACE` file when running `update-repos` when
bzlmod is enabled by [@&#8203;cgrindel](https://togithub.com/cgrindel)
in
[https://github.com/bazelbuild/bazel-gazelle/pull/1589](https://togithub.com/bazelbuild/bazel-gazelle/pull/1589)
- Make `go_deps.from_file` compatible with Go 1.21 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1605](https://togithub.com/bazelbuild/bazel-gazelle/pull/1605)
- go_repository: fix missing default GOPROXY by
[@&#8203;sluongng](https://togithub.com/sluongng) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1602](https://togithub.com/bazelbuild/bazel-gazelle/pull/1602)
- fix: patch support for dir named workspace by
[@&#8203;michaellzc](https://togithub.com/michaellzc) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1606](https://togithub.com/bazelbuild/bazel-gazelle/pull/1606)
- Revert "go_repository: fix missing default GOPROXY
([#&#8203;1602](https://togithub.com/bazelbuild/bazel-gazelle/issues/1602))"
by [@&#8203;sluongng](https://togithub.com/sluongng) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1609](https://togithub.com/bazelbuild/bazel-gazelle/pull/1609)
- Upgrade `golang.org/x/mod` Vendor to Support Go 1.21 by
[@&#8203;alan910127](https://togithub.com/alan910127) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1611](https://togithub.com/bazelbuild/bazel-gazelle/pull/1611)
- fix: go_repository: never shadow a module with a compatibility mapping
for major versions. by [@&#8203;reltuk](https://togithub.com/reltuk) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1608](https://togithub.com/bazelbuild/bazel-gazelle/pull/1608)
- bug fix: don't generate invalid go_binary rules for empty main
packages by [@&#8203;andyscott](https://togithub.com/andyscott) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1618](https://togithub.com/bazelbuild/bazel-gazelle/pull/1618)
- Fix wrong Kotlin Support link in README. by
[@&#8203;duckladydinh](https://togithub.com/duckladydinh) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1619](https://togithub.com/bazelbuild/bazel-gazelle/pull/1619)
- bzlmod: Verify that the lockfile is platform-independent by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1617](https://togithub.com/bazelbuild/bazel-gazelle/pull/1617)
- Add gazelle_rust under supported languages by
[@&#8203;Calsign](https://togithub.com/Calsign) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1620](https://togithub.com/bazelbuild/bazel-gazelle/pull/1620)
- replace golang.org/x/tools with
golang.org/x/tools/go/[email protected] by
[@&#8203;malt3](https://togithub.com/malt3) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1603](https://togithub.com/bazelbuild/bazel-gazelle/pull/1603)
- Implement Merger interface by
[@&#8203;Whoaa512](https://togithub.com/Whoaa512) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1569](https://togithub.com/bazelbuild/bazel-gazelle/pull/1569)
- Improve Gazelle launcher's runfiles discovery on Windows by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1604](https://togithub.com/bazelbuild/bazel-gazelle/pull/1604)
- Add an entry for "github.com/googleapis/gax-go/v2" to
default_gazelle_overrides.bzl by
[@&#8203;andrewmbenton](https://togithub.com/andrewmbenton) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1623](https://togithub.com/bazelbuild/bazel-gazelle/pull/1623)
- add a go_test directive to enable generating go_test targets per
\_test.go file by [@&#8203;shahms](https://togithub.com/shahms) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1597](https://togithub.com/bazelbuild/bazel-gazelle/pull/1597)
- Detect whether Gazelle itself is a Bazel module by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1624](https://togithub.com/bazelbuild/bazel-gazelle/pull/1624)
- prepare release 0.33 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1615](https://togithub.com/bazelbuild/bazel-gazelle/pull/1615)

#### New Contributors

- [@&#8203;sfc-gh-ptabor](https://togithub.com/sfc-gh-ptabor) made their
first contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1582](https://togithub.com/bazelbuild/bazel-gazelle/pull/1582)
- [@&#8203;kolloch](https://togithub.com/kolloch) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1590](https://togithub.com/bazelbuild/bazel-gazelle/pull/1590)
- [@&#8203;shahms](https://togithub.com/shahms) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1596](https://togithub.com/bazelbuild/bazel-gazelle/pull/1596)
- [@&#8203;michaellzc](https://togithub.com/michaellzc) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1606](https://togithub.com/bazelbuild/bazel-gazelle/pull/1606)
- [@&#8203;alan910127](https://togithub.com/alan910127) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1611](https://togithub.com/bazelbuild/bazel-gazelle/pull/1611)
- [@&#8203;reltuk](https://togithub.com/reltuk) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1608](https://togithub.com/bazelbuild/bazel-gazelle/pull/1608)
- [@&#8203;andyscott](https://togithub.com/andyscott) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1618](https://togithub.com/bazelbuild/bazel-gazelle/pull/1618)
- [@&#8203;duckladydinh](https://togithub.com/duckladydinh) made their
first contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1619](https://togithub.com/bazelbuild/bazel-gazelle/pull/1619)
- [@&#8203;Calsign](https://togithub.com/Calsign) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1620](https://togithub.com/bazelbuild/bazel-gazelle/pull/1620)
- [@&#8203;malt3](https://togithub.com/malt3) made their first
contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1603](https://togithub.com/bazelbuild/bazel-gazelle/pull/1603)
- [@&#8203;andrewmbenton](https://togithub.com/andrewmbenton) made their
first contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1623](https://togithub.com/bazelbuild/bazel-gazelle/pull/1623)

**Full Changelog**:
bazel-contrib/bazel-gazelle@v0.32.0...v0.33.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/aspect-build/rules_py).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager Nov 24, 2023
….0 (#486)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/bazelbuild/bazel-gazelle](https://togithub.com/bazelbuild/bazel-gazelle)
| require | minor | `v0.33.0` -> `v0.34.0` |

---

### Release Notes

<details>
<summary>bazelbuild/bazel-gazelle
(github.com/bazelbuild/bazel-gazelle)</summary>

###
[`v0.34.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.34.0)

[Compare
Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.33.0...v0.34.0)

#### What's Changed

- update readme for v0.33.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1627](https://togithub.com/bazelbuild/bazel-gazelle/pull/1627)
- Remove golang.org/x/crypto dep by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1631](https://togithub.com/bazelbuild/bazel-gazelle/pull/1631)
- Fix map_kind with empty rules by
[@&#8203;lbcjbb](https://togithub.com/lbcjbb) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1441](https://togithub.com/bazelbuild/bazel-gazelle/pull/1441)
- fix: add missing bzl_library declaration and dep by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1633](https://togithub.com/bazelbuild/bazel-gazelle/pull/1633)
- chore: add bzl_test to ensure that bzl_library declarations exist by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1634](https://togithub.com/bazelbuild/bazel-gazelle/pull/1634)
- Set runfiles environment variables for Gazelle by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1632](https://togithub.com/bazelbuild/bazel-gazelle/pull/1632)
- address comments from
[#&#8203;1597](https://togithub.com/bazelbuild/bazel-gazelle/issues/1597)
by [@&#8203;shahms](https://togithub.com/shahms) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1628](https://togithub.com/bazelbuild/bazel-gazelle/pull/1628)
- Fix kinds and stmt by [@&#8203;birunts](https://togithub.com/birunts)
in
[https://github.com/bazelbuild/bazel-gazelle/pull/1613](https://togithub.com/bazelbuild/bazel-gazelle/pull/1613)
- Export workspace file in go_repository_config.bzl by
[@&#8203;mortenmj](https://togithub.com/mortenmj) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1641](https://togithub.com/bazelbuild/bazel-gazelle/pull/1641)
- Add github.com/google/gnostic-models to default_gazelle_overrides.bzl
by [@&#8203;mortenmj](https://togithub.com/mortenmj) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1645](https://togithub.com/bazelbuild/bazel-gazelle/pull/1645)
- Support parsing labels that begin '@&#8203;@&#8203;' by
[@&#8203;mark-thm](https://togithub.com/mark-thm) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1651](https://togithub.com/bazelbuild/bazel-gazelle/pull/1651)
- Fix path for google/gnostic-models by
[@&#8203;mortenmj](https://togithub.com/mortenmj) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1652](https://togithub.com/bazelbuild/bazel-gazelle/pull/1652)
- fix(bzlmod): allow passing build_extra_args in gazelle_override by
[@&#8203;casuallyhostile](https://togithub.com/casuallyhostile) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1648](https://togithub.com/bazelbuild/bazel-gazelle/pull/1648)
- prepare release 0.34.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/bazel-gazelle/pull/1656](https://togithub.com/bazelbuild/bazel-gazelle/pull/1656)

#### New Contributors

- [@&#8203;casuallyhostile](https://togithub.com/casuallyhostile) made
their first contribution in
[https://github.com/bazelbuild/bazel-gazelle/pull/1648](https://togithub.com/bazelbuild/bazel-gazelle/pull/1648)

**Full Changelog**:
bazel-contrib/bazel-gazelle@v0.33.0...v0.34.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44LjExIiwidXBkYXRlZEluVmVyIjoiMzYuMTAwLjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

---------

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Co-authored-by: Chuck Grindel <[email protected]>
jeromep-stripe pushed a commit to jeromep-stripe/bazel-gazelle that referenced this pull request Mar 22, 2024
…l-contrib#1648)

* fix(bzlmod): allow build_extra_args in gazelle_override

* bump MODULE.bazel.lock

* add DEFAULT_BUILD_EXTRA_ARGS_BY_PATH

* fix return statement in _get_build_extra_args

* bazel mod deps

* pr comments: remove empty line in _get_build_extra_args

* bazel mod deps in tests/bcr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bzlmod: allow build_extra_args in gazelle_override
4 participants