Skip to content

Commit

Permalink
Release 8.10.0
Browse files Browse the repository at this point in the history
  • Loading branch information
chetanshanbagBV authored Oct 27, 2022
1 parent 5f88c13 commit 0e71abd
Show file tree
Hide file tree
Showing 9 changed files with 44 additions and 4 deletions.
2 changes: 1 addition & 1 deletion BVSDK.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

Pod::Spec.new do |s|
s.name = "BVSDK"
s.version = '8.9.1'
s.version = '8.10.0'
s.homepage = 'https://developer.bazaarvoice.com/'
s.license = { :type => 'Commercial', :text => 'See https://developer.bazaarvoice.com/API_Terms_of_Use' }
s.author = { 'Bazaarvoice' => '[email protected]' }
Expand Down
2 changes: 2 additions & 0 deletions BVSDK.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -3754,6 +3754,7 @@
buildSettings = {
CODE_SIGN_STYLE = Manual;
DEVELOPMENT_TEAM = "";
"DEVELOPMENT_TEAM[sdk=macosx*]" = TH9FFAVND4;
GCC_PREPROCESSOR_DEFINITIONS = (
"$(inherited)",
"COCOAPODS=1",
Expand All @@ -3774,6 +3775,7 @@
buildSettings = {
CODE_SIGN_STYLE = Manual;
DEVELOPMENT_TEAM = "";
"DEVELOPMENT_TEAM[sdk=macosx*]" = TH9FFAVND4;
GCC_PREPROCESSOR_DEFINITIONS = (
"$(inherited)",
"COCOAPODS=1",
Expand Down
2 changes: 1 addition & 1 deletion BVSDK/BVCommon/BVSDKConstants.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#define BVSDKConstants_h

/// Provides the master version of the SDK.
#define BV_SDK_VERSION @"8.9.1"
#define BV_SDK_VERSION @"8.10.1"

/// Conversation SDK Version
#define SDK_HEADER_NAME @"X-UA-BV-SDK"
Expand Down
2 changes: 2 additions & 0 deletions BVSDK/BVConversations/Display/Model/BVProductStatistics.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

#import "BVGenericConversationsResult.h"
#import "BVReviewStatistic.h"
#import "BVQAStatistics.h"
#import <Foundation/Foundation.h>

/*
Expand All @@ -17,5 +18,6 @@
@property(nullable) NSString *productId;
@property(nullable) BVReviewStatistic *reviewStatistics;
@property(nullable) BVReviewStatistic *nativeReviewStatistics;
@property(nullable) BVQAStatistics *qaStatisctics;

@end
2 changes: 2 additions & 0 deletions BVSDK/BVConversations/Display/Model/BVProductStatistics.m
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ - (nonnull id)initWithApiResponse:(nonnull NSDictionary *)apiResponse
initWithApiResponse:productStatistics[@"ReviewStatistics"]];
self.nativeReviewStatistics = [[BVReviewStatistic alloc]
initWithApiResponse:productStatistics[@"NativeReviewStatistics"]];
self.qaStatisctics = [[BVQAStatistics alloc]
initWithApiResponse:productStatistics[@"QAStatistics"]];
}
return self;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
typedef NS_ENUM(NSInteger, BVBulkRatingIncludeTypeValue) {
BVBulkRatingIncludeTypeValueBulkRatingReviews,
BVBulkRatingIncludeTypeValueBulkRatingNativeReviews,
BVBulkRatingIncludeTypeValueBulkRatingQuestions,
BVBulkRatingIncludeTypeValueBulkRatingNativeAnswers,
BVBulkRatingIncludeTypeValueBulkRatingAll
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,14 @@ - (nonnull instancetype)initWithRawValue:(NSInteger)rawValue {
case BVBulkRatingIncludeTypeValueBulkRatingNativeReviews:
self.value = @"NativeReviews";
break;
case BVBulkRatingIncludeTypeValueBulkRatingNativeAnswers:
self.value = @"Answers";
break;
case BVBulkRatingIncludeTypeValueBulkRatingQuestions:
self.value = @"Questions";
break;
case BVBulkRatingIncludeTypeValueBulkRatingAll:
self.value = @"Reviews,NativeReviews";
self.value = @"Reviews,NativeReviews,Answers,Questions";
break;
}
}
Expand Down
2 changes: 1 addition & 1 deletion BVSDK/Support/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<key>CFBundlePackageType</key>
<string>FMWK</string>
<key>CFBundleShortVersionString</key>
<string>8.9.1</string>
<string>8.10.0</string>
<key>CFBundleVersion</key>
<string>1</string>
<key>LSApplicationCategoryType</key>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,4 +130,30 @@ class InlineRatingsDisplayTests: XCTestCase {

}

func testInlineRatingsQAstatistics() {

let configDict = ["clientId": "apitestcustomer",
"apiKeyConversations": "caB45h2jBqXFw1OE043qoMBD1gJC8EwFNCjktzgwncXY4"];
BVSDKManager.configure(withConfiguration: configDict, configType: .staging)


let expectation = self.expectation(description: "testInlineRatingsQAstatistics")

let request =
BVBulkRatingsRequest(productIds: ["data-gen-moppq9ekthfzbc6qff3bqokie"], statistics: .bulkRatingAll)
.filter(on: .bulkRatingContentLocale, relationalFilterOperatorValue: .equalTo, values: ["en_US"])

request.load({ (response) in
XCTAssertEqual(response.results.count, 1)
XCTAssertNotNil(response.results[0].qaStatisctics?.totalQuestionCount)
XCTAssertNotNil(response.results[0].qaStatisctics?.totalAnswerCount)
expectation.fulfill()
}) { (error) in
XCTFail("inline ratings request error: \(error)")
}

self.waitForExpectations(timeout: 10) { (error) in
XCTAssertNil(error, "Something went horribly wrong, request took too long.")
}
}
}

0 comments on commit 0e71abd

Please sign in to comment.