Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for summary networks [WIP] #202

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

rusty-electron
Copy link
Contributor

I will be adding more commits to this PR as per instructions from @LarsKue.

Updates to test fixtures:

  • tests/conftest.py: Modified the summary_network fixture to accept the summary_dim parameter.
  • tests/test_networks/conftest.py: Added new fixtures for summary_dim, key_dim, and various network instances (lst_net, set_transformer, set_transformer_key_dim_variation, deep_set).

New test cases:

  • tests/test_networks/test_summary_networks.py: Introduced new test cases test_compute_metrics and test_set_transformer_with_key_dim to verify the functionality of the new attributes and ensure the correctness of the network outputs.

@LarsKue
Copy link
Contributor

LarsKue commented Oct 11, 2024

Thank you for the PR. Please make sure that the linter passes before merging.

@LarsKue LarsKue added unit tests A new set of tests needs to be added. good first issue Good for first-time contributors labels Oct 11, 2024
@paul-buerkner
Copy link
Contributor

In an attempt to merge this PR, I noticed that there are some unknown arguments used in set_transformer, namely key_dim and num_attention_blocks.

@LarsKue I think you will need to check and fix this before you can merge it as I don't understand the context in which these changes were made.

@LarsKue
Copy link
Contributor

LarsKue commented Nov 25, 2024

@paul-buerkner please never merge PRs that do not at the very least pass all tests, unless you have very good reason to. I will look into this as soon as I have a time slot available.

@paul-buerkner
Copy link
Contributor

paul-buerkner commented Nov 25, 2024

I did not intend to merge this PR without consultation (even if all tests would have passed, which they are not because of the issue I brought up). I just wanted to move it forward. My earlier message was unclear in this regard. Sorry for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for first-time contributors unit tests A new set of tests needs to be added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants