-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tests for summary networks [WIP] #202
base: dev
Are you sure you want to change the base?
add tests for summary networks [WIP] #202
Conversation
* add fixtures for some summary network types * add a test for compute_metrics method of summary networks
Thank you for the PR. Please make sure that the linter passes before merging. |
In an attempt to merge this PR, I noticed that there are some unknown arguments used in @LarsKue I think you will need to check and fix this before you can merge it as I don't understand the context in which these changes were made. |
@paul-buerkner please never merge PRs that do not at the very least pass all tests, unless you have very good reason to. I will look into this as soon as I have a time slot available. |
I did not intend to merge this PR without consultation (even if all tests would have passed, which they are not because of the issue I brought up). I just wanted to move it forward. My earlier message was unclear in this regard. Sorry for that. |
I will be adding more commits to this PR as per instructions from @LarsKue.
Updates to test fixtures:
tests/conftest.py
: Modified thesummary_network
fixture to accept thesummary_dim
parameter.tests/test_networks/conftest.py
: Added new fixtures forsummary_dim
,key_dim
, and various network instances (lst_net
,set_transformer
,set_transformer_key_dim_variation
,deep_set
).New test cases:
tests/test_networks/test_summary_networks.py
: Introduced new test casestest_compute_metrics
andtest_set_transformer_with_key_dim
to verify the functionality of the new attributes and ensure the correctness of the network outputs.