Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fixes #1

Open
wants to merge 24 commits into
base: refactor/site_info
Choose a base branch
from
Open

Conversation

camirmas
Copy link

This fixes some of the low-hanging test failures and cleans up a few items related to the current PR changes to SiteInfo

camirmas and others added 5 commits July 31, 2023 15:27
* Update CI Action to run on PRs

* Add CI Badge to README.md

* Fix failing hybrid test
@camirmas camirmas force-pushed the refactor/site_info branch 3 times, most recently from f97a4a4 to 1aab611 Compare August 3, 2023 20:30
camirmas and others added 6 commits August 3, 2023 18:37
Fixes some of the clearer test failures. Still getting some numerical failures of varying magnitudes, which will need to be investigated further.
After a fresh env install, I received test failures related to Pyomo not finding glpk. This fixes that issue by updating the README to specify a `glpk` install via conda.
* Update CI Action to run on PRs

* Add CI Badge to README.md

* Fix failing hybrid test
bayc pushed a commit that referenced this pull request Aug 11, 2023
Add option to cost based on constant pipe diameter
bayc pushed a commit that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant