-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test fixes #1
Open
camirmas
wants to merge
24
commits into
bayc:refactor/site_info
Choose a base branch
from
camirmas:refactor/site_info
base: refactor/site_info
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Test fixes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update CI Action to run on PRs * Add CI Badge to README.md * Fix failing hybrid test
camirmas
force-pushed
the
refactor/site_info
branch
3 times, most recently
from
August 3, 2023 20:30
f97a4a4
to
1aab611
Compare
Fixes some of the clearer test failures. Still getting some numerical failures of varying magnitudes, which will need to be investigated further.
After a fresh env install, I received test failures related to Pyomo not finding glpk. This fixes that issue by updating the README to specify a `glpk` install via conda.
* Update CI Action to run on PRs * Add CI Badge to README.md * Fix failing hybrid test
camirmas
force-pushed
the
refactor/site_info
branch
from
August 4, 2023 01:38
1aab611
to
8d6956a
Compare
camirmas
force-pushed
the
refactor/site_info
branch
from
August 4, 2023 03:31
1bc6e9c
to
c3c1a04
Compare
camirmas
force-pushed
the
refactor/site_info
branch
from
August 4, 2023 03:45
c3c1a04
to
f400696
Compare
camirmas
force-pushed
the
refactor/site_info
branch
from
August 4, 2023 18:20
e678a29
to
6b683f9
Compare
camirmas
force-pushed
the
refactor/site_info
branch
from
August 4, 2023 18:42
d93e3b0
to
5568dc3
Compare
camirmas
force-pushed
the
refactor/site_info
branch
from
August 7, 2023 18:33
f8a537f
to
2ea0437
Compare
camirmas
force-pushed
the
refactor/site_info
branch
from
August 7, 2023 20:11
9b0a429
to
08a99b1
Compare
camirmas
force-pushed
the
refactor/site_info
branch
from
August 7, 2023 20:45
08a99b1
to
85663f9
Compare
bayc
pushed a commit
that referenced
this pull request
Aug 11, 2023
Add option to cost based on constant pipe diameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some of the low-hanging test failures and cleans up a few items related to the current PR changes to
SiteInfo