add compete data to teaminfo #558
Conversation
|
Rank and PerfCard wouldn't be ready, cuz backend doesn't exist yet for that :// Backend doesn't (yet) expose rank, totals wins, or total losses. We should work on that first! (You could, thought you'd have to set up first...) So in all, if you could get backend set up, then maybe work on the backend side first? Otherwise just hold off on this and find another cool frontend issue :// |
|
I believe we'd previously decided that total wins and total losses should be computed on frontend based on team history (similar to what's already being done, but adapted to the new endpoint) in which case backend should be already ready. But perhaps that decision has changed recently? @j-mao any input? |
|
idts? after some trial, we decided to just put this on backend. pagination
is annoying and sending all data is too big
…On Sun, Jan 15, 2023 at 3:19 PM Gaurav Arya ***@***.***> wrote:
I believe we'd previously decided that total wins and total losses should
be computed on frontend based on team history, in which case backend should
be already ready. @j-mao <https://github.com/j-mao> any input?
—
Reply to this email directly, view it on GitHub
<#558 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADK4FJDNKISLMZNSNCKY4U3WSSAYTANCNFSM6AAAAAAT4ACVOQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
n8kim1
force-pushed
the
compete-based-teamcard
branch
from
1485f0d to
6faed96
Compare
n8kim1
force-pushed
the
compete-based-teamcard
branch
from
6faed96 to
48d62e2
Compare
n8kim1
force-pushed
the
compete-based-teamcard
branch
from
95cb175 to
d3c809a
Compare
| detail=False, | ||
| methods=["post"], | ||
| serializer_class=None, | ||
| permission_classes=(IsAuthenticated, IsEpisodeAvailable), |
There was a problem hiding this comment.
I might suggest removing IsAuthenticated, to allow this to be viewable by the public
|
|
||
| @action( | ||
| detail=False, | ||
| methods=["post"], |
There was a problem hiding this comment.
This should probably be get, since it’s a non mutator.
draft: My staging is messed up so Ihave not tested. Because I cant test, I'm not refactoring the api file, more focused on functionality for the deadline. This pr changes teaminfo, just from comments. Should I add win-loss to the teamcard component?