Revise scrimmage creation #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8kim1
force-pushed
the
webinfra-scrimmage-better
branch
from
f7e5663 to
5523ce0
Compare
n8kim1
force-pushed
the
webinfra-scrimmage-better
branch
from
58819be to
b80780d
Compare
(now that it's actually integrated)
(seems accurate)
n8kim1
commented
Jan 4, 2021
Comment on lines
+87
to
+88
| red_submission_id = red_team_sub.last_1_id | ||
| blue_submission_id = blue_team_sub.last_1_id |
n8kim1
commented
Jan 4, 2021
backend/api/views.py
Outdated
Comment on lines
135
to
136
| red_submission_id = TeamSubmission.objects.get(pk=red_team_id).last_1_id | ||
| blue_submission_id = TeamSubmission.objects.get(pk=blue_team_id).last_1_id |
There was a problem hiding this comment.
this is bad: won't work for tours.
after sub ids are stored in db, get them from there
j-mao
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
does a crazy amount of things, to simplify codebase and patch out some bugs. For #126, #42.
create_scrimmage_helper, accept_scrimmage_helper do the bulk of all the scrimmage creation work.
The same endpoints that created scrimmages still do so. But now they just tease out arguments, and pass it to these methods.
Tournament matches are now unranked, as intended; other misc bugfixes.
Sets tournament_id of standard matches to -1 (better design for later)
Also changes some models, because we need some new statuses of scrimmages, and need to save a scrimmage's maps for info transfer once it goes from created to accepted.
Remaining TODOs here are all for speeding up code -- they don't change functionality. leaving that for a future time