Display round-trip time on the subtitle of the custom service ping #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastienwirtz
requested changes
Oct 25, 2024
There was a problem hiding this comment.
Nice addition @sebersta, thanks for contributing!
Just a few thing, and we should be good to go.
Comment on lines
+11
to
+13
| <template v-if="status === 'online' && item.showRtt"> | ||
| {{ rtt }} ms | ||
| </template> |
There was a problem hiding this comment.
It would be great to still have the subtitle if showRtt is set to false, could you add it?
Also maybe, if showRtt is set to true, and service is not online, it could say "Unknown RTT" or something like that?
|
|
||
| ```yaml | ||
| - name: "Awesome app" | ||
| type: Ping | ||
| logo: "assets/tools/sample.png" | ||
| subtitle: "Bookmark example" |
There was a problem hiding this comment.
If you support both subtitle and showRtt (see comment below), you can keep this line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Display round-trip time on the subtitle of the custom service ping. Toggled by showRtt, default set to false.
Type of change
Checklist:
config.ymlfile